Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5842)

Unified Diff: chrome/browser/resources/extensions/extension_commands_overlay.js

Issue 1162293008: Fix some lingering WebUI focus issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +1 fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_commands_overlay.js
diff --git a/chrome/browser/resources/extensions/extension_commands_overlay.js b/chrome/browser/resources/extensions/extension_commands_overlay.js
index ab56eb4e1719d0ef3a5c43d1ebc754ff27abc07d..190330b6b25056e4252557dc32f9fca6985965ee 100644
--- a/chrome/browser/resources/extensions/extension_commands_overlay.js
+++ b/chrome/browser/resources/extensions/extension_commands_overlay.js
@@ -34,8 +34,9 @@ cr.define('extensions', function() {
this.extensionCommandList_ = new ExtensionCommandList(
/**@type {HTMLDivElement} */($('extension-command-list')));
- $('extension-commands-dismiss').addEventListener('click',
- this.handleDismiss_.bind(this));
Dan Beam 2015/06/04 03:30:29 this was short-circuiting the focus restoration co
+ $('extension-commands-dismiss').addEventListener('click', function() {
+ cr.dispatchEvent(overlay, 'cancelOverlay');
dmazzoni 2015/06/04 03:34:56 Just curious, is there a reason this is dispatchEv
Dan Beam 2015/06/04 18:50:35 Done. (and closure compiled for first time and act
+ });
// The ExtensionList will update us with its data, so we don't need to
// handle that here.
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extension_error_overlay.js » ('j') | ui/webui/resources/js/cr/ui/overlay.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698