Fix some lingering WebUI focus issues.

chrome/browser/resources/extensions/extension_commands_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_command_list.js">
 
 cr.define('extensions', function() {
   'use strict';
 
   // The Extension Commands list object that will be used to show the commands
@@ skipping 16 matching lines @@
      */
     initializePage: function() {
       var overlay = $('overlay');
       cr.ui.overlay.setupOverlay(overlay);
       cr.ui.overlay.globalInitialization();
       overlay.addEventListener('cancelOverlay', this.handleDismiss_.bind(this));
 
       this.extensionCommandList_ = new ExtensionCommandList(
           /**@type {HTMLDivElement} */($('extension-command-list')));
 
-      $('extension-commands-dismiss').addEventListener('click',
-          this.handleDismiss_.bind(this));

[Dan Beam, 2015/06/04 03:30:29]

this was short-circuiting the focus restoration code.

+      $('extension-commands-dismiss').addEventListener('click', function() {
+        cr.dispatchEvent(overlay, 'cancelOverlay');

[dmazzoni, 2015/06/04 03:34:56]

Just curious, is there a reason this is dispatchEvent and the others are
dispatchSimpleEvent?

[Dan Beam, 2015/06/04 18:50:35]

Done. (and closure compiled for first time and actually tried this code)

+      });
 
       // The ExtensionList will update us with its data, so we don't need to
       // handle that here.
     },
 
     /**
      * Handles a click on the dismiss button.
      * @param {Event} e The click event.
      */
     handleDismiss_: function(e) {
@@ skipping 26 matching lines @@
     $('no-commands').hidden = hasAnyCommands;
     overlay.extensionCommandList_.classList.toggle(
         'empty-extension-commands-list', !hasAnyCommands);
   };
 
   // Export
   return {
     ExtensionCommandsOverlay: ExtensionCommandsOverlay
   };
 });