Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: net/base/network_quality_estimator.cc

Issue 1162293004: Use request start time for estimating network quality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_quality_estimator.cc
diff --git a/net/base/network_quality_estimator.cc b/net/base/network_quality_estimator.cc
index e012a99d72fdcc752cf4e9406f8e61651315598a..710703e11a2cf1cba2367c3927b5cf0a27e46a5b 100644
--- a/net/base/network_quality_estimator.cc
+++ b/net/base/network_quality_estimator.cc
@@ -7,6 +7,7 @@
#include <string>
#include "base/metrics/histogram.h"
+#include "net/base/load_timing_info.h"
#include "net/base/net_util.h"
#include "net/base/network_quality.h"
#include "net/url_request/url_request.h"
@@ -49,7 +50,12 @@ void NetworkQualityEstimator::NotifyDataReceived(const URLRequest& request,
return;
base::TimeTicks now = base::TimeTicks::Now();
- base::TimeDelta request_duration = now - request.creation_time();
+
+ LoadTimingInfo load_timing_info;
+ request.GetLoadTimingInfo(&load_timing_info);
+ DCHECK_NE(load_timing_info.request_start, base::TimeTicks());
bengr 2015/06/01 23:23:34 Do all requests have load timing info?
tbansal1 2015/06/01 23:53:36 Seems like yes. request_start is populated in URLR
+
+ base::TimeDelta request_duration = now - load_timing_info.request_start;
DCHECK_GE(request_duration, base::TimeDelta());
if (!bytes_read_since_last_connection_change_)
fastest_RTT_since_last_connection_change_ = request_duration;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698