Load the Chrome OS TTS engine manifest from the file system isntead of resources.

Load the Chrome OS TTS engine manifest from the file system isntead of resources.

This makes it easier to push new versions of the engine since the manifest
goes into the same repository (Chromium OS) as the rest of the extension.

BUG=495086
Committed: https://crrev.com/2cad95c37baab26a53159b6fe9198fab2399470d
Cr-Commit-Position: refs/heads/master@{#332814}

[Peter Lundblad, 2015-06-01 16:22:13]

plundblad@chromium.org changed reviewers:
+ dmazzoni@chromium.org, kalman@chromium.org

[Peter Lundblad, 2015-06-01 16:22:14]

NOTE: This depends on the files being available in the filesystem on Chromeos,
which is handled in separate CLS that will be committed first.

[dmazzoni, 2015-06-01 16:59:29]

lgtm

Nice cleanup, thanks! It's great to avoid that duplication.

[not at google - send to devlin, 2015-06-01 17:39:37]

lgtm

https://codereview.chromium.org/1162283002/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/1162283002/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/component_loader.cc:98: <<
root_directory.Append(manifest_filename).AsUTF8Unsafe()
Annoying that FilePath doesn't define <<

https://codereview.chromium.org/1162283002/diff/1/chrome/common/extensions/ex...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/1162283002/diff/1/chrome/common/extensions/ex...
chrome/common/extensions/extension_constants.h:198: extern const
base::FilePath::CharType kGuestManifestFilename[];
FilePath::CharType is more correct I suppose, but I'd prefer to keep it the same
as the rest of the file (e.g. note kChromeVoxExtensionPath,
kSpeechSynthesisExtensionPath, etc) as a const char[].

[Peter Lundblad, 2015-06-02 10:12:37]

kalman@chromium.org writes:
> lgtm
> 
> 
> 
> 
>
https://codereview.chromium.org/1162283002/diff/1/chrome/browser/extensions/c...
> File chrome/browser/extensions/component_loader.cc (right):
> 
>
https://codereview.chromium.org/1162283002/diff/1/chrome/browser/extensions/c...
> chrome/browser/extensions/component_loader.cc:98: <<
> root_directory.Append(manifest_filename).AsUTF8Unsafe()
> Annoying that FilePath doesn't define <<

Ack.

>
https://codereview.chromium.org/1162283002/diff/1/chrome/common/extensions/ex...
> File chrome/common/extensions/extension_constants.h (right):
> 
>
https://codereview.chromium.org/1162283002/diff/1/chrome/common/extensions/ex...
> chrome/common/extensions/extension_constants.h:198: extern const
> base::FilePath::CharType kGuestManifestFilename[];
> FilePath::CharType is more correct I suppose, but I'd prefer to keep it
> the same as the rest of the file (e.g. note kChromeVoxExtensionPath,
> kSpeechSynthesisExtensionPath, etc) as a const char[].

OK, changed it back, yay for c++'s weak typedefs;)

> https://codereview.chromium.org/1162283002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2015-06-02 10:43:02]

plundblad@chromium.org changed reviewers:
+ jhawkins@chromium.org

[Peter Lundblad, 2015-06-02 10:43:02]

+jhawkins for chrome/browser/resources and chrome/browser/browser_resources.grd

[James Hawkins, 2015-06-02 16:45:55]

lgtm

[Peter Lundblad, 2015-06-02 20:17:58]

+jam for chrome/browser/extensions/component_extension_whitelist that was added
today. Note that this is not a new extension, but just changing how the manifest
is stored.

[Peter Lundblad, 2015-06-03 07:16:00]

plundblad@chromium.org changed reviewers:
+ jam@chromium.org

[Peter Lundblad, 2015-06-03 07:16:00]

Actually +jam;)  See previous comment.

[jam, 2015-06-03 15:25:41]

lgtm

[Peter Lundblad, 2015-06-04 09:38:03]

The CQ bit was checked by plundblad@chromium.org

[Peter Lundblad, 2015-06-04 09:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, jhawkins@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1162283002/#ps20001
(title: "Update component extension whitelist.")

[commit-bot: I haz the power, 2015-06-04 09:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162283002/20001

[commit-bot: I haz the power, 2015-06-04 11:11:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-04 11:12:37]

Patchset 2 (id:??) landed as
https://crrev.com/2cad95c37baab26a53159b6fe9198fab2399470d
Cr-Commit-Position: refs/heads/master@{#332814}