Exposes datetime attribute.

Exposes datetime attribute.

According to ARIA spec,
http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#att-datetime-time,
datetime attribute should be exposed as a object attribute.

This patch changes how to expose HTML attributes such as type for
text-input, aria-dropeffect and aria-grabbed.
The variable, html_attributes, from ui::AXNodeData is used instead of adding
additional attributes.

BUG=480861
TBR=aboxhall

Committed: https://crrev.com/85cf6b004467da8d1d50969ded4692ca9a76f053
Cr-Commit-Position: refs/heads/master@{#333974}

[je_julie(Not used), 2015-06-09 08:41:15]

Patchset #3 (id:40001) has been deleted

[je_julie(Not used), 2015-06-09 11:18:43]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[je_julie(Not used), 2015-06-09 11:18:44]

Hi Dominic,

This patch exposes datetime attribute for time tag.

It also removes some string attributes, dropeffect, text_input_type and grabbed.
Because these attributes are originally from html attributes without any
modification, I think we can use html_attributes from AXNodeData without
AddStringAttribute and AddBoolAttribute.
If this patch is merged, we can remove exposed APIs for these attributes from
Blink.

For chromevox, it changes textInputType to type to use html attribute, 'type'.

PTAL.

[dmazzoni, 2015-06-09 16:23:33]

I'm not sure whether moving towards the use of HTML attributes instead of
accessibility attributes is better or worse.

I'll start a separate thread.

https://codereview.chromium.org/1162263008/diff/60001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1162263008/diff/60001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3405: // Expose
dropeffect attribute.
What do you think of just iterating over all HTML attributes and exposing
everything with an aria- prefix? That would match what Firefox does.

I guess we'd have to exclude a few like aria-live that we're already handling,
above.

[je_julie(Not used), 2015-06-10 02:16:32]

Dominic,
Thanks for your comment.

I added some comment about the reason why I think it's better to use html
attributes from AXNodeData instead string or bool attributes from it.

PTAL.

https://codereview.chromium.org/1162263008/diff/60001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1162263008/diff/60001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3405: // Expose
dropeffect attribute.
On 2015/06/09 16:23:32, dmazzoni wrote:
> What do you think of just iterating over all HTML attributes and exposing
> everything with an aria- prefix? That would match what Firefox does.
> 
> I guess we'd have to exclude a few like aria-live that we're already handling,
> above.

When I looking into the inspection result from Accessibility Viewer,
Firefox has some html attributes depending on html tag for IAccessible2->Object
Attributes and all aria-attributes for ARIA->Attributes.('->' means inspection
menu depth.)
Chrome also has some html attributes for IAccessible2->Object Attributes and all
aria-attributes for ARIA->Attributes.

Because this part is for handling of IAccessible2->Object Attributes, I think we
don't need to expose all aria-attributes here.
I think it's enough to handle some html attribute according to spec. WDYT?

https://codereview.chromium.org/1162263008/diff/60001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/1162263008/diff/60001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:385:
dst->html_attributes.push_back(std::make_pair(name, value));
We copied all html attributes to html_attributes from AXNodeData here.
Because AXNodeData has the fields, html_attributes, string_attributes, and so
on, if we copied several html attributes which doesn't need modification from
original attribute values to string_attributes or others again, I think it's a
redundant work and consumes spaces.
WDYT?

[dmazzoni, 2015-06-10 06:43:48]

lgtm

https://codereview.chromium.org/1162263008/diff/60001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/1162263008/diff/60001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:385:
dst->html_attributes.push_back(std::make_pair(name, value));
On 2015/06/10 02:16:31, je_julie wrote:
> We copied all html attributes to html_attributes from AXNodeData here.
> Because AXNodeData has the fields, html_attributes, string_attributes, and so
> on, if we copied several html attributes which doesn't need modification from
> original attribute values to string_attributes or others again, I think it's a
> redundant work and consumes spaces.
> WDYT?

Absolutely true.

I think we could save even more space by only copying the html attributes we
will ever need. But let's save that for a future change.

[je_julie(Not used), 2015-06-10 07:27:18]

je_julie.kim@samsung.com changed reviewers:
+ aboxhall@chromium.org

[je_julie(Not used), 2015-06-10 07:29:20]

On 2015/06/10 06:43:48, dmazzoni wrote:
> lgtm
> 
>
https://codereview.chromium.org/1162263008/diff/60001/content/renderer/access...
> File content/renderer/accessibility/blink_ax_tree_source.cc (right):
> 
>
https://codereview.chromium.org/1162263008/diff/60001/content/renderer/access...
> content/renderer/accessibility/blink_ax_tree_source.cc:385:
> dst->html_attributes.push_back(std::make_pair(name, value));
> On 2015/06/10 02:16:31, je_julie wrote:
> > We copied all html attributes to html_attributes from AXNodeData here.
> > Because AXNodeData has the fields, html_attributes, string_attributes, and
so
> > on, if we copied several html attributes which doesn't need modification
from
> > original attribute values to string_attributes or others again, I think it's
a
> > redundant work and consumes spaces.
> > WDYT?
> 
> Absolutely true.
> 
> I think we could save even more space by only copying the html attributes we
> will ever need. But let's save that for a future change.

Dominic, Thanks.
I added Alice as a reviewer for
chrome/renderer/resources/extensions/automation/automation_node.js.
Alice, Could you take a look?

[je_julie(Not used), 2015-06-11 13:49:20]

Alice, PTAL.

[dmazzoni, 2015-06-11 16:09:52]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-06-11 16:10:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162263008/60001

[dmazzoni, 2015-06-11 16:10:09]

Adding Alice as TBR. We should fix the OWNERS file there.

[commit-bot: I haz the power, 2015-06-11 17:25:18]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-06-11 17:26:21]

Patchset 3 (id:??) landed as
https://crrev.com/85cf6b004467da8d1d50969ded4692ca9a76f053
Cr-Commit-Position: refs/heads/master@{#333974}