Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: Source/core/loader/EmptyClients.h

Issue 1162263007: Cleanup: Move code common in ChromeClient JavaScript dialog functions to a function template. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 96
97 virtual void setMenubarVisible(bool) override { } 97 virtual void setMenubarVisible(bool) override { }
98 virtual bool menubarVisible() override { return false; } 98 virtual bool menubarVisible() override { return false; }
99 99
100 virtual void setResizable(bool) override { } 100 virtual void setResizable(bool) override { }
101 101
102 virtual bool shouldReportDetailedMessageForSource(LocalFrame&, const String& ) override { return false; } 102 virtual bool shouldReportDetailedMessageForSource(LocalFrame&, const String& ) override { return false; }
103 virtual void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, c onst String&, unsigned, const String&, const String&) override { } 103 virtual void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, c onst String&, unsigned, const String&, const String&) override { }
104 104
105 virtual bool canRunBeforeUnloadConfirmPanel() override { return false; } 105 virtual bool canRunBeforeUnloadConfirmPanel() override { return false; }
106 virtual bool runBeforeUnloadConfirmPanelInternal(const String&, LocalFrame*) override { return true; } 106 virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String&) override { return true; }
107 107
108 virtual void closeWindowSoon() override { } 108 virtual void closeWindowSoon() override { }
109 109
110 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) override { } 110 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) override { }
111 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) overri de { return false; } 111 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) overri de { return false; }
112 virtual bool runJavaScriptPromptInternal(LocalFrame*, const String&, const S tring&, String&) override { return false; } 112 virtual bool runJavaScriptPromptInternal(LocalFrame*, const String&, const S tring&, String&) override { return false; }
113 113
114 virtual bool hasOpenedPopup() const override { return false; } 114 virtual bool hasOpenedPopup() const override { return false; }
115 virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame &, PopupMenuClient*) override; 115 virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame &, PopupMenuClient*) override;
116 virtual DOMWindow* pagePopupWindowForTesting() const override { return nullp tr; } 116 virtual DOMWindow* pagePopupWindowForTesting() const override { return nullp tr; }
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 virtual ~EmptyDragClient() {} 309 virtual ~EmptyDragClient() {}
310 virtual DragDestinationAction actionMaskForDrag(DragData*) override { return DragDestinationActionNone; } 310 virtual DragDestinationAction actionMaskForDrag(DragData*) override { return DragDestinationActionNone; }
311 virtual void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTra nsfer*, LocalFrame*, bool) override { } 311 virtual void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTra nsfer*, LocalFrame*, bool) override { }
312 }; 312 };
313 313
314 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&); 314 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);
315 315
316 } // namespace blink 316 } // namespace blink
317 317
318 #endif // EmptyClients_h 318 #endif // EmptyClients_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698