|
An object may become a column spanner or cease to be one even if column-span doesn't change.
If something with column-span:all becomes floated or out-of-flow
positioned, it ceases to be a spanner. And conversely, if something
with column-span:all is floated or out-of-flow positioned, and later
on becomes non-floated in-flow, it becomes a spanner.
Since we need to cope with such situations, there's no point in
forcing a layout object reattach when the value of column-span
changes, so removed that check.
BUG= 497195
R=dsinclair@chromium.org,jchaffraix@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196679
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+194 lines, -11 lines) |
Patch |
|
A |
LayoutTests/fast/multicol/dynamic/abspos-becomes-spanner.html
|
View
|
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/abspos-becomes-spanner-expected.html
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/float-becomes-spanner.html
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/float-becomes-spanner-expected.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/sole-spanner-becomes-abspos-crash.html
|
View
|
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/fast/multicol/dynamic/sole-spanner-becomes-abspos-crash-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/spanner-ancestor-becomes-spanner.html
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/spanner-ancestor-becomes-spanner-expected.html
|
View
|
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/spanner-becomes-abspos-crash.html
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/spanner-becomes-abspos-crash-expected.txt
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/spanner-becomes-float.html
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/dynamic/spanner-becomes-float-expected.html
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutBox.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutMultiColumnFlowThread.h
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutMultiColumnFlowThread.cpp
|
View
|
|
4 chunks |
+46 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp
|
View
|
|
2 chunks |
+25 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/style/ComputedStyle.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|