Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(71)

Issue 1162223002: DevTools: properly update paint profiler upon new event being set (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
alph, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: properly update paint profiler upon new event being set We used to update paint profiler only upon onShow(), which accidentally worked because the view kept being re-attached when selection changed. Now that we keep the view, we need to to kick update explicitly when a new event is set. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196500

Patch Set 1 #

Patch Set 2 : added a test #

Total comments: 1

Patch Set 3 : skip the test under virtual/deferred #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1 line) Patch
M LayoutTests/NeverFixTests View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/paint-profiler-update.html View 1 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/paint-profiler-update-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePaintProfilerView.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
caseq
4 years, 11 months ago (2015-06-01 12:02:38 UTC) #2
pfeldman
On 2015/06/01 12:02:38, caseq wrote: A test?
4 years, 11 months ago (2015-06-01 12:11:58 UTC) #3
caseq
Added a test, ptal.
4 years, 11 months ago (2015-06-01 15:12:27 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/1162223002/diff/40001/LayoutTests/inspector/tracing/paint-profiler-update.html File LayoutTests/inspector/tracing/paint-profiler-update.html (right): https://codereview.chromium.org/1162223002/diff/40001/LayoutTests/inspector/tracing/paint-profiler-update.html#newcode49 LayoutTests/inspector/tracing/paint-profiler-update.html:49: InspectorTest.addSniffer(panel, "_appendDetailsTabsForTraceEventAndShowDetails", onRecordDetailsReady, false); Is there a way ...
4 years, 11 months ago (2015-06-01 16:13:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162223002/40001
4 years, 11 months ago (2015-06-01 16:30:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64200)
4 years, 11 months ago (2015-06-01 18:20:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162223002/80001
4 years, 11 months ago (2015-06-04 12:06:40 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 13:55:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196500

Powered by Google App Engine
This is Rietveld 408576698