Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1162203007: Add move constructor for FX string types. (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : I can't spell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M core/include/fxcrt/fx_string.h View 1 2 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. I thought I had done this a long time ago, but it ...
5 years, 6 months ago (2015-06-05 22:03:38 UTC) #2
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-05 22:12:15 UTC) #3
Tom Sepez
5 years, 6 months ago (2015-06-05 22:23:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9b440b4da2103096ae29dc7ece533128341ea1d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698