Unit tests have been created for the GPUTiming.

Unit tests have been created for the GPUTiming.

We have traditionally tested all of the GPUTiming functionalities within
GPUTracer since GPUTracer utilizes GPUTiming extensively. With the
introduction of gl_unittests as well as GPUTiming getting more
complicated it makes sense to have GPUTiming specific unit tests. This
CL is the first step in moving towards that direction, simply moving
all of the GPUTiming GL queries into a fake query class which can
handle the query expectations.

R=sievers@chromium.org, vmiura@chromium.org
BUG=453965, 345227
Committed: https://crrev.com/26bd4c4dd55f61976b2ce58bacb7c82d60df7c5b
Cr-Commit-Position: refs/heads/master@{#333642}

[David Yen, 2015-06-05 22:02:09]

On 2015/06/05 22:00:08, David Yen wrote:

This CL simply moves over the mock queries from gpu_tracer_unittest to
gpu_timing_fake so it should be mostly seen as a refactor (with some minor
changes). I am tempted to go ahead and move all GPUTiming specific unit tests
over to gpu_timing_unittest as well but I think that would be harder to review
and should be in its own contained CL. PTAL.

[vmiura, 2015-06-06 00:08:57]

lgtm

[David Yen, 2015-06-09 21:05:31]

On 2015/06/06 00:08:57, vmiura wrote:
> lgtm

ping

[no sievers, 2015-06-09 22:56:41]

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gl_tests.gyp
File ui/gl/gl_tests.gyp (right):

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gl_tests.gyp#newc...
ui/gl/gl_tests.gyp:37: '<(DEPTH)/third_party/khronos',
nit: I thought you had already moved this out of the OS-block in another cl.

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gpu_timing_fake.h
File ui/gl/gpu_timing_fake.h (right):

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gpu_timing_fake.h...
ui/gl/gpu_timing_fake.h:16: class GPUTimingFakeGLQueries {
Can you make the class name match the file name?

[David Yen, 2015-06-09 23:04:24]

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gl_tests.gyp
File ui/gl/gl_tests.gyp (right):

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gl_tests.gyp#newc...
ui/gl/gl_tests.gyp:37: '<(DEPTH)/third_party/khronos',
On 2015/06/09 22:56:41, sievers wrote:
> nit: I thought you had already moved this out of the OS-block in another cl.

Yes, that CL is still in the commit queue. I will wait for that to land to
ensure these merge properly.

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gpu_timing_fake.h
File ui/gl/gpu_timing_fake.h (right):

https://codereview.chromium.org/1162203006/diff/20001/ui/gl/gpu_timing_fake.h...
ui/gl/gpu_timing_fake.h:16: class GPUTimingFakeGLQueries {
On 2015/06/09 22:56:41, sievers wrote:
> Can you make the class name match the file name?

Done.

[no sievers, 2015-06-09 23:30:34]

lgtm

[David Yen, 2015-06-09 23:36:54]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2015-06-09 23:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1162203006/#ps80001
(title: "Reverted egl unit test changes, wrong cl")

[commit-bot: I haz the power, 2015-06-09 23:40:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162203006/80001

[commit-bot: I haz the power, 2015-06-10 01:39:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-10 01:40:40]

Patchset 5 (id:??) landed as
https://crrev.com/26bd4c4dd55f61976b2ce58bacb7c82d60df7c5b
Cr-Commit-Position: refs/heads/master@{#333642}