Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1162203004: [Autofill] More variant-related code deletion (Closed)

Created:
5 years, 6 months ago by Evan Stade
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] More variant-related code deletion BUG=493856 Committed: https://crrev.com/8c191a648f0b1d69a5bc7f5c823a15d944b78f95 Cr-Commit-Position: refs/heads/master@{#333177}

Patch Set 1 #

Patch Set 2 : its all relative #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -117 lines) Patch
M components/autofill/core/browser/autofill_profile.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 2 8 chunks +14 lines, -71 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc View 1 3 chunks +4 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
this chunk is more bite-sized
5 years, 6 months ago (2015-06-05 19:19:36 UTC) #2
please use gerrit instead
lgtm lgtm nom nom nom
5 years, 6 months ago (2015-06-05 20:20:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162203004/20001
5 years, 6 months ago (2015-06-05 20:21:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/78636) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-05 20:30:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162203004/40001
5 years, 6 months ago (2015-06-05 23:04:44 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 23:41:50 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:42:46 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8c191a648f0b1d69a5bc7f5c823a15d944b78f95
Cr-Commit-Position: refs/heads/master@{#333177}

Powered by Google App Engine
This is Rietveld 408576698