Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: runtime/observatory/lib/src/elements/service_ref.dart

Issue 1162133002: Introduce Instance.kind. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: regis feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/service_ref.dart
diff --git a/runtime/observatory/lib/src/elements/service_ref.dart b/runtime/observatory/lib/src/elements/service_ref.dart
index e238141b0d739e101b32c68edeedf45ddecc3a31..ba00201775696e768b429bbe77c8efbd6b8b25fe 100644
--- a/runtime/observatory/lib/src/elements/service_ref.dart
+++ b/runtime/observatory/lib/src/elements/service_ref.dart
@@ -102,17 +102,15 @@ class AnyServiceRefElement extends ObservatoryElement {
ServiceRefElement element = new Element.tag('script-ref');
element.ref = ref;
return element;
+ case 'Instance':
+ case 'Sentinel':
+ ServiceRefElement element = new Element.tag('instance-ref');
+ element.ref = ref;
+ return element;
default:
- if (ref.isInstance ||
- ref.isSentinel) { // TODO(rmacnak): Separate this out.
- ServiceRefElement element = new Element.tag('instance-ref');
- element.ref = ref;
- return element;
- } else {
- SpanElement element = new Element.tag('span');
- element.text = "<<Unknown service ref: $ref>>";
- return element;
- }
+ SpanElement element = new Element.tag('span');
+ element.text = "<<Unknown service ref: $ref>>";
+ return element;
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_view.html ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698