Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 1162113004: Refactoring: Change some functions in MarkupFormatter static (Closed)

Created:
4 years, 11 months ago by hajimehoshi
Modified:
4 years, 11 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Change some functions in MarkupFormatter static Some of those functions in MarkupFormatter don't use the member variables so we can change them to be static. This CL does that. Now MarkupAccumulator and MarkupFormatter have samely named functions and most of those in MarkupAccumulator are implemented just with calling counterparts in MarkupFormatter. This CL also removes those redundant delegations. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -69 lines) Patch
M Source/core/editing/MarkupAccumulator.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 3 chunks +4 lines, -49 lines 0 comments Download
M Source/core/editing/MarkupFormatter.h View 2 chunks +7 lines, -8 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hajimehoshi
PTAL
4 years, 11 months ago (2015-06-04 04:20:16 UTC) #2
tkent
lgtm
4 years, 11 months ago (2015-06-04 04:23:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162113004/1
4 years, 11 months ago (2015-06-04 04:23:31 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 05:28:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196459

Powered by Google App Engine
This is Rietveld 408576698