Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1162103004: Revert of Roll PDFium to b29338d (Closed)

Created:
5 years, 6 months ago by engedy
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll PDFium to b29338d (patchset #2 id:20001 of https://codereview.chromium.org/1159433007/) Reason for revert: Causes compile errors on "Linux GN Clobber" bot: ../../third_party/pdfium/core/src/fxcrt/fx_basic_memmgr_unittest.cpp:23:31:error: expression result unused [-Werror,-Wunused-value] EXPECT_DEATH_IF_SUPPORTED(FX_Alloc(int, kMaxIntAlloc), ""); Archived full build log: https://goo.gl/4OImxB. Original issue's description: > Roll PDFium to b29338d > > This brings in: > b29338d Fix windows compile: fix size_t vs. int mismatch > e06b686 kill IPDF_DocParser(). > 4ff7a42 Fix heap use after free in Document::DoFieldDelay and Document::delay > 8e1b608 Add missing comma to third_party.gyp > cafa3fd Run V8 in predictable mode for pdfium_test > 8ba4a3c Fix suppressions for 2015-05-28 drop > 878b819 Roll DEPS to pick up 2015-05-28 corpus drop. > 6b776fe Fix ALL the include guards. > 14f57a1 Remove rendundant ../include from paths of files in include/ directory > cddfde0 Upgrade openjpeg to r3002 > 5f566b3 Update copy of safe_math_impl.h to take a fix from upstream: > e6406b3 Fix four annoying warnings: Two "set but unused". > bc4b82e Fix an endless loop in CJBig2_HuffmanTable::parseFromCodedBuffer > 79569e7 Get test running scripts to detect and report common error. > e9ccc9b Integer overflow in CJBig2_Image::expand > 3a25130 Tidy public fpdfview.h and fpdf_flatten.h. > b190fc2 Turn on warnings for usage of disabled V8 APIs > 981a346 Re-land: Remove FX_Alloc() null checks now that it can't return NULL. > bf4aa2c Revert "Remove FX_Alloc() null checks now that it can't return NULL." > eb65277 Remove FX_Alloc() null checks now that it can't return NULL. > 59f4b44 Fix Heap Overflow in CJBig2_Image::expand > 3b60890 Cleanup if early return from opj_j2k_copy_default_tcp_and_create_tcd(). > 3fea540 Replace v8::Handle with v8::Local and v8::Persistent with v8::Global > 0c94bc4 Change FX_Alloc to FX_Try_Alloc in _JpegEncode > 31b3a2b Add safe FX_Alloc2D() macro > a88e3a1 Add myself to OWNERS file > d94df88 Replace deprecated with non-deprecated V8 APIs > 1962d61 Fix leaks in embedder test's FlateEncode() usage and in FlateEncode(). > 69b4bc7 Disable allocation tests that hose the bot. > acae925 Initialize members of CPDF_TextPageFind class. > 61ffad8 Fix leaks in the embedder tests themselves. > 9f6f348 Abort on OOM by default in FX_Alloc(). > dc0bd92 Remove FX_NEW_VECTOR() macros. > 7f3b99a Fix potential UAF in ConcatInPlace. > b60617f Fix another batch of compiler warnings. > > BUG=459215, 482639, 483981, 486538, 487928, 488302 > R=thestig@chromium.org > > Committed: https://crrev.com/6e5d15268c5d75ba15189ce0a6050845068eb06b > Cr-Commit-Position: refs/heads/master@{#332514} TBR=thestig@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459215, 482639, 483981, 486538, 487928, 488302 Committed: https://crrev.com/af1125ea286450ceecc23a37c6710bcf0b2d1ce6 Cr-Commit-Position: refs/heads/master@{#332579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
engedy
Created Revert of Roll PDFium to b29338d
5 years, 6 months ago (2015-06-03 09:13:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162103004/1
5 years, 6 months ago (2015-06-03 09:14:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 09:15:38 UTC) #3
engedy
First failing build was: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/911.
5 years, 6 months ago (2015-06-03 09:16:16 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 09:16:30 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af1125ea286450ceecc23a37c6710bcf0b2d1ce6
Cr-Commit-Position: refs/heads/master@{#332579}

Powered by Google App Engine
This is Rietveld 408576698