chrome/browser/signin/fake_gaia_cookie_manager_service.cc - Issue 1162103003: ListAccounts will return the Gaia ID as well as the email of the account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/fake_gaia_cookie_manager_service.cc

Issue 1162103003: ListAccounts will return the Gaia ID as well as the email of the account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: show raw email in signin internals Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/signin/oauth2_login_manager.cc ('K') | « chrome/browser/signin/cross_device_promo_unittest.cc ('k') | chrome/browser/ui/webui/chromeos/login/authenticated_user_email_retriever.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/fake_gaia_cookie_manager_service.cc

diff --git a/chrome/browser/signin/fake_gaia_cookie_manager_service.cc b/chrome/browser/signin/fake_gaia_cookie_manager_service.cc

index 0203d46f396c373d23fa9cb74a71fc8671e6dbc5..4c767d06ba559b848b67f23b1316bfa87209d684 100644

--- a/chrome/browser/signin/fake_gaia_cookie_manager_service.cc

+++ b/chrome/browser/signin/fake_gaia_cookie_manager_service.cc

@@ -61,7 +61,7 @@ void FakeGaiaCookieManagerService::SetListAccountsResponseOneAccount(

GaiaUrls::GetInstance()->ListAccountsURLWithSource(

GaiaConstants::kChromeSource),

base::StringPrintf(

- "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, 1]]]",

+ "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, 1, \"22\"]]]",

account),

net::HTTP_OK,

net::URLRequestStatus::SUCCESS);

@@ -74,7 +74,7 @@ void FakeGaiaCookieManagerService::SetListAccountsResponseOneAccountWithExpiry(

GaiaUrls::GetInstance()->ListAccountsURLWithSource(

GaiaConstants::kChromeSource),

base::StringPrintf(

- "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, %d]]]",

+ "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, %d, \"22\"]]]",

account, expired ? 0 : 1),

net::HTTP_OK,

net::URLRequestStatus::SUCCESS);

@@ -87,8 +87,8 @@ void FakeGaiaCookieManagerService::SetListAccountsResponseTwoAccounts(

GaiaUrls::GetInstance()->ListAccountsURLWithSource(

GaiaConstants::kChromeSource),

base::StringPrintf(

- "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, 1], "

- "[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, 1]]]",

+ "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, 1, \"22\"], "

+ "[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, 1, \"24\"]]]",

account1, account2),

net::HTTP_OK,

net::URLRequestStatus::SUCCESS);

@@ -102,8 +102,8 @@ void FakeGaiaCookieManagerService::SetListAccountsResponseTwoAccountsWithExpiry(

GaiaUrls::GetInstance()->ListAccountsURLWithSource(

GaiaConstants::kChromeSource),

base::StringPrintf(

- "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, %d], "

- "[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, %d]]]",

+ "[\"f\", [[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, %d, \"28\"], "

+ "[\"b\", 0, \"n\", \"%s\", \"p\", 0, 0, 0, 0, %d, \"29\"]]]",

account1, account1_expired ? 0 : 1,

account2, account2_expired ? 0 : 1),

net::HTTP_OK,