chrome/browser/signin/account_reconcilor_unittest.cc - Issue 1162103003: ListAccounts will return the Gaia ID as well as the email of the account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/account_reconcilor_unittest.cc

Issue 1162103003: ListAccounts will return the Gaia ID as well as the email of the account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: show raw email in signin internals Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/chromeos/login/signin/oauth2_login_manager.cc ('K') | « chrome/browser/resources/signin_internals/signin_index.html ('k') | chrome/browser/signin/cross_device_promo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/account_reconcilor_unittest.cc

diff --git a/chrome/browser/signin/account_reconcilor_unittest.cc b/chrome/browser/signin/account_reconcilor_unittest.cc

index fe138495977587bdc20e8e5090500867f90cc568..4948d6b1ec36983582562f47b1f888eb2ba8b86b 100644

--- a/chrome/browser/signin/account_reconcilor_unittest.cc

+++ b/chrome/browser/signin/account_reconcilor_unittest.cc

@@ -330,10 +330,10 @@ TEST_F(AccountReconcilorTest, GetAccountsFromCookieSuccess) {

base::RunLoop().RunUntilIdle();

ASSERT_EQ(AccountReconcilor::State::APPLYING_CHANGES, reconcilor->GetState());

- std::vector<std::pair<std::string, bool> > accounts;

+ std::vector<gaia::ListedAccount> accounts;

ASSERT_TRUE(cookie_manager_service()->ListAccounts(&accounts));

ASSERT_EQ(1u, accounts.size());

- ASSERT_EQ(account_id, accounts[0].first);

+ ASSERT_EQ(account_id, accounts[0].email);

}

TEST_F(AccountReconcilorTest, GetAccountsFromCookieFailure) {

@@ -350,7 +350,7 @@ TEST_F(AccountReconcilorTest, GetAccountsFromCookieFailure) {

reconcilor->GetState());

base::RunLoop().RunUntilIdle();

- std::vector<std::pair<std::string, bool> > accounts;

+ std::vector<gaia::ListedAccount> accounts;

ASSERT_FALSE(cookie_manager_service()->ListAccounts(&accounts));

ASSERT_EQ(0u, accounts.size());

@@ -397,7 +397,7 @@ TEST_P(AccountReconcilorTest, StartReconcileCookiesDisabled) {

ASSERT_FALSE(reconcilor->is_reconcile_started_);

base::RunLoop().RunUntilIdle();

- std::vector<std::pair<std::string, bool> > accounts;

+ std::vector<gaia::ListedAccount> accounts;

// This will be the first call to ListAccounts.

ASSERT_FALSE(cookie_manager_service()->ListAccounts(&accounts));

ASSERT_FALSE(reconcilor->is_reconcile_started_);