chrome/browser/chromeos/login/signin/oauth2_login_verifier.h - Issue 1162103003: ListAccounts will return the Gaia ID as well as the email of the account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin/oauth2_login_verifier.h

Issue 1162103003: ListAccounts will return the Gaia ID as well as the email of the account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: show raw email in signin internals Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/signin/oauth2_login_manager.cc ('K') | « chrome/browser/chromeos/login/signin/oauth2_login_manager.cc ('k') | chrome/browser/chromeos/login/signin/oauth2_login_verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin/oauth2_login_verifier.h

diff --git a/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h b/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h

index 9c4a52c7dcf6dd6bf317f1fb81d3a916f1cc196e..f105a1f58c6242997dacdd05a4a9a72c9fa2bb2b 100644

--- a/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h

+++ b/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h

@@ -32,7 +32,7 @@ class OAuth2LoginVerifier : public GaiaCookieManagerService::Observer {

// Invoked when account list is retrieved during post-merge session

// verification.

virtual void OnListAccountsSuccess(

- const std::vector<std::pair<std::string, bool>>& accounts) = 0;

+ const std::vector<gaia::ListedAccount>& accounts) = 0;

// Invoked when post-merge session verification fails.

virtual void OnListAccountsFailure(bool connection_error) = 0;

@@ -57,8 +57,8 @@ class OAuth2LoginVerifier : public GaiaCookieManagerService::Observer {

const std::string& account_id,

const GoogleServiceAuthError& error) override;

void OnGaiaAccountsInCookieUpdated(

- const std::vector<std::pair<std::string, bool> >& accounts,

- const GoogleServiceAuthError& error) override;

+ const std::vector<gaia::ListedAccount>& accounts,

+ const GoogleServiceAuthError& error) override;

OAuth2LoginVerifier::Delegate* delegate_;

GaiaCookieManagerService* cookie_manager_service_;