Notify on console when play fails

Notify on console when play fails

In some cases a media file is prevented from playing
unless the play API is invoked on user action.
This used to happen silently. Now with this change,
it happens with a warning on the console instead.

BUG=365779
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196528

[keenanb, 2015-06-03 22:45:39]

keenanb@google.com changed reviewers:
+ jww@chromium.org

[keenanb, 2015-06-03 22:46:30]

hey joel, i know you haven't heard about this issue before, but can you review
this.

[jww, 2015-06-03 22:58:51]

lgtm, with nits.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1919: // prevent autoplay, and make it
known
Please remove this comment, as it is unnecessary.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1921: "play",
Please put these arguments on one line.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1923: "the API can be initiated only by
the user.");
Please make this message match the message in the Fullscreen API, so it should
read: 
   API can only be initiated by a user gesture.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1925:
ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageString));
Please put this argument on the previous line.

[keenanb, 2015-06-04 00:07:12]

keenanb@google.com changed reviewers:
+ philipj@opera.com

[keenanb, 2015-06-04 00:07:13]

Hi philipj. Would you mind doing an owner review of the following file

  Source/core/html/HTMLMediaElement.cpp

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1919: // prevent autoplay, and make it
known
On 2015/06/03 22:58:51, jww wrote:
> Please remove this comment, as it is unnecessary.

Done.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1921: "play",
On 2015/06/03 22:58:51, jww wrote:
> Please put these arguments on one line.

Done.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1923: "the API can be initiated only by
the user.");
On 2015/06/03 22:58:51, jww wrote:
> Please make this message match the message in the Fullscreen API, so it should
> read: 
>    API can only be initiated by a user gesture.

Done.

https://codereview.chromium.org/1162063004/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:1925:
ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageString));
On 2015/06/03 22:58:51, jww wrote:
> Please put this argument on the previous line.

Done.

[philipj_slow, 2015-06-04 08:16:38]

LGTM % interface name

https://codereview.chromium.org/1162063004/diff/20001/Source/core/html/HTMLMe...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1162063004/diff/20001/Source/core/html/HTMLMe...
Source/core/html/HTMLMediaElement.cpp:1919: String message =
ExceptionMessages::failedToExecute("play", "MediaElement", "API can only be
initiated by a user gesture.");
This should say "HTMLMediaElement", there's no interface called only
"MediaElement".

[keenanb, 2015-06-04 19:46:50]

The CQ bit was checked by keenanb@google.com

[keenanb, 2015-06-04 19:46:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jww@chromium.org,
philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1162063004/#ps40001
(title: "Interface name")

[commit-bot: I haz the power, 2015-06-04 19:47:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162063004/40001

[commit-bot: I haz the power, 2015-06-04 20:56:16]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196528