extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h - Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make dtor protected Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('K') | « extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('k') | extensions/renderer/resources/guest_view/guest_view_container.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

index c39bf93740b25185b6448538a4a81e35218d086e..796358ef8b853df368cca6a44fbccde1fdfde0e4 100644

--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

@@ -41,7 +41,6 @@ class MimeHandlerViewContainer : public guest_view::GuestViewContainer,

MimeHandlerViewContainer(content::RenderFrame* render_frame,

const std::string& mime_type,

const GURL& original_url);

- ~MimeHandlerViewContainer() override;

static std::vector<MimeHandlerViewContainer*> FromRenderFrame(

content::RenderFrame* render_frame);

@@ -74,6 +73,9 @@ class MimeHandlerViewContainer : public guest_view::GuestViewContainer,

// Post |message| to the guest.

void PostMessageFromValue(const base::Value& message);

+ protected:

+ ~MimeHandlerViewContainer() override;

private:

// Message handlers.

void OnCreateMimeHandlerViewGuestACK(int element_instance_id);