extensions/renderer/guest_view/guest_view_internal_custom_bindings.h - Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make dtor protected Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/guest_view/extensions_guest_view_container.cc ('K') | « extensions/renderer/guest_view/extensions_guest_view_container.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

index 0f84a39abe7ccc14ac5d7018a9108f02b7be69cf..6a6d6c305321cb2816c97222316fe3cad4e3b15c 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

@@ -51,6 +51,9 @@ class GuestViewInternalCustomBindings : public ObjectBackedNativeHandler {

// Window JavaScript object for that RenderView.

void GetContentWindow(const v8::FunctionCallbackInfo<v8::Value>& args);

+ // Destroys the GuestViewContainer given an element instance ID in |args|.

+ void DestroyContainer(const v8::FunctionCallbackInfo<v8::Value>& args);

// GetViewFromID takes a view ID, and returns the GuestView element associated

// with that ID, if one exists. Otherwise, null is returned.

void GetViewFromID(const v8::FunctionCallbackInfo<v8::Value>& args);