extensions/renderer/guest_view/extensions_guest_view_container.cc - Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync @tott Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/guest_view/extensions_guest_view_container.h ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/extensions_guest_view_container.cc

diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc

index 1bd857543ca82bc60eeef524e771bd4620b027b9..d1005031b23ee4e0e5575854c631cb7db97cda31 100644

--- a/extensions/renderer/guest_view/extensions_guest_view_container.cc

+++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc

@@ -19,6 +19,9 @@ ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(

}

ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {

+void ExtensionsGuestViewContainer::OnDestroy() {

// Call the destruction callback, if one is registered.

if (!destruction_callback_.IsEmpty()) {

v8::HandleScope handle_scope(destruction_isolate_);