Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync @tott Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_manager.h
diff --git a/content/renderer/browser_plugin/browser_plugin_manager.h b/content/renderer/browser_plugin/browser_plugin_manager.h
index 34386656ef0da03c6ad104e542824651d0e45007..2e9d4df66c3e2c9b1ca1153abfc69017cd98330b 100644
--- a/content/renderer/browser_plugin/browser_plugin_manager.h
+++ b/content/renderer/browser_plugin/browser_plugin_manager.h
@@ -34,9 +34,11 @@ class CONTENT_EXPORT BrowserPluginManager : public RenderProcessObserver {
// BrowserPlugin is responsible for associating itself with the
// BrowserPluginManager via AddBrowserPlugin. When it is destroyed, it is
// responsible for removing its association via RemoveBrowserPlugin.
- BrowserPlugin* CreateBrowserPlugin(
- RenderFrame* render_frame,
- scoped_ptr<BrowserPluginDelegate> delegate);
+ // The |delegate| is expected to manage its own lifetime.
+ // Generally BrowserPlugin calls DidDestroyElement() on the delegate and
+ // right now the delegate destroys itself once it hears that callback.
+ BrowserPlugin* CreateBrowserPlugin(RenderFrame* render_frame,
+ BrowserPluginDelegate* delegate);
void Attach(int browser_plugin_instance_id);
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | content/renderer/browser_plugin/browser_plugin_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698