Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync @tott Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 379369790a512541dc2fc3277e46a1813d63c3f7..179499477707fdda5f768cf58ae6891586bae6b8 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -55,8 +55,6 @@ class CONTENT_EXPORT BrowserPlugin :
// A request to enable hardware compositing.
void EnableCompositing(bool enable);
- void UpdateInternalInstanceId();
-
// Provided that a guest instance ID has been allocated, this method attaches
// this BrowserPlugin instance to that guest.
void Attach();
@@ -146,13 +144,14 @@ class CONTENT_EXPORT BrowserPlugin :
// uniquely identifies a guest WebContents that's hosted by this
// BrowserPlugin.
BrowserPlugin(RenderFrame* render_frame,
- scoped_ptr<BrowserPluginDelegate> delegate);
+ BrowserPluginDelegate* delegate);
~BrowserPlugin() override;
gfx::Rect view_rect() const { return view_rect_; }
void ShowSadGraphic();
+ void UpdateInternalInstanceId();
// IPC message handlers.
// Please keep in alphabetical order.
@@ -201,7 +200,9 @@ class CONTENT_EXPORT BrowserPlugin :
std::vector<EditCommand> edit_commands_;
- scoped_ptr<BrowserPluginDelegate> delegate_;
+ // We call lifetime managing methods on |delegate_|, but we do not directly
+ // own this. The delegate destroys itself.
+ BrowserPluginDelegate* delegate_;
// Weak factory used in v8 |MakeWeak| callback, since the v8 callback might
// get called after BrowserPlugin has been destroyed.
« no previous file with comments | « content/public/renderer/browser_plugin_delegate.h ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698