Fix http://dartbug.com/23578:

runtime/vm/compiler_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
 #include "vm/object.h"
 #include "vm/symbols.h"
 #include "vm/unit_test.h"
 
 namespace dart {
 
-DECLARE_FLAG(bool, enable_type_checks);
-
 TEST_CASE(CompileScript) {
   const char* kScriptChars =
       "class A {\n"
       "  static foo() { return 42; }\n"
       "}\n";
   String& url = String::Handle(String::New("dart-test:CompileScript"));
   String& source = String::Handle(String::New(kScriptChars));
   Script& script = Script::Handle(Script::New(url,
                                               source,
                                               RawScript::kScriptTag));
@@ skipping 46 matching lines @@
 TEST_CASE(RegenerateAllocStubs) {
   const char* kScriptChars =
             "class A {\n"
             "}\n"
             "unOpt() => new A(); \n"
             "optIt() => new A(); \n"
             "A main() {\n"
             "  return unOpt();\n"
             "}\n";
 
-  bool old_enable_type_checks = FLAG_enable_type_checks;
-  FLAG_enable_type_checks = true;
+  // Isolate::Current()->flags().set_checked(true);

[Florian Schneider, 2015/06/08 11:25:49]

 Why is this commmented out?

[Ivan Posva, 2015/06/08 11:53:57]

Because it is being enabled after the isolate has already been setup, which is
not a good thing to do.

As discussed I will change the code above to do an explicit check for subtype of
A.

   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   Dart_Handle result = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
   RawLibrary* raw_library = Library::RawCast(Api::UnwrapHandle(lib));
   Library& lib_handle = Library::ZoneHandle(raw_library);
   Class& cls = Class::Handle(
       lib_handle.LookupClass(String::Handle(Symbols::New("A"))));
   EXPECT(!cls.IsNull());
 
   Isolate* isolate = Isolate::Current();
   StubCode* stub_code = isolate->stub_code();
   const Code& stub = Code::Handle(isolate,
                                   stub_code->GetAllocationStubForClass(cls));
   Class& owner = Class::Handle();
   owner ^= stub.owner();
   owner.DisableAllocationStub();
   result = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
 
   owner.DisableAllocationStub();
   result = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
 
   owner.DisableAllocationStub();
   result = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
-
-  FLAG_enable_type_checks = old_enable_type_checks;
 }
 
 
 TEST_CASE(EvalExpression) {
   const char* kScriptChars =
       "int ten = 2 * 5;              \n"
       "get dot => '.';               \n"
       "class A {                     \n"
       "  var apa = 'Herr Nilsson';   \n"
       "  calc(x) => '${x*ten}';      \n"
@@ skipping 49 matching lines @@
     val = lib.Evaluate(expression, Array::empty_array(), Array::empty_array());
   }
 
   EXPECT(!val.IsNull());
   EXPECT(!val.IsError());
   EXPECT(val.IsInteger());
   EXPECT_EQ(7, Integer::Cast(val).AsInt64Value());
 }
 
 }  // namespace dart