Fix http://dartbug.com/23578:

runtime/lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 153 matching lines @@
 
 static bool CreateIsolate(Isolate* parent_isolate,
                           IsolateSpawnState* state,
                           char** error) {
   Dart_IsolateCreateCallback callback = Isolate::CreateCallback();
   if (callback == NULL) {
     *error = strdup("Null callback specified for isolate creation\n");
     return false;
   }
 
+  Dart_IsolateFlags api_flags;
+  state->isolate_flags()->CopyTo(&api_flags);
+
   void* init_data = parent_isolate->init_callback_data();
   Isolate* child_isolate = reinterpret_cast<Isolate*>(
       (callback)(state->script_url(),
                  state->function_name(),
                  state->package_root(),
+                 &api_flags,
                  init_data,
                  error));
   if (child_isolate == NULL) {
     return false;
   }
-  // TODO(iposva): Evaluate whether it's ok to override the embedder's setup.
-  // Currently the strict_compilation flag is ignored if it's false and
-  // checked-mode was enabled using a command-line flag. The command-line flag
-  // overrides the user code's request.
-  child_isolate->set_strict_compilation(state->checked_mode());
   if (!state->is_spawn_uri()) {
     // For isolates spawned using the spawn semantics we set
     // the origin_id to the origin_id of the parent isolate.
     child_isolate->set_origin_id(parent_isolate->origin_id());
   }
   state->set_isolate(reinterpret_cast<Isolate*>(child_isolate));
   return true;
 }
 
 
@@ skipping 28 matching lines @@
     Function& func = Function::Handle();
     func = Closure::function(closure);
     if (func.IsImplicitClosureFunction() && func.is_static()) {
 #if defined(DEBUG)
       Context& ctx = Context::Handle();
       ctx = Closure::context(closure);
       ASSERT(ctx.num_variables() == 0);
 #endif
       // Get the parent function so that we get the right function name.
       func = func.parent_function();
-      bool checkedFlag = isolate->strict_compilation();
       Spawn(isolate, new IsolateSpawnState(port.Id(),
                                            func,
                                            message,
-                                           paused.value(),
-                                           checkedFlag));
+                                           paused.value()));
       return Object::null();
     }
   }
   const String& msg = String::Handle(String::New(
       "Isolate.spawn expects to be passed a static or top-level function"));
   Exceptions::ThrowArgumentError(msg);
   return Object::null();
 }
 
 
@@ skipping 18 matching lines @@
   }
 
   char* utf8_package_root = NULL;
   if (!package_root.IsNull()) {
     const intptr_t len = Utf8::Length(package_root);
     utf8_package_root = zone->Alloc<char>(len + 1);
     package_root.ToUTF8(reinterpret_cast<uint8_t*>(utf8_package_root), len);
     utf8_package_root[len] = '\0';
   }
 
-  bool checkedFlag;
-  if (checked.IsNull()) {
-    checkedFlag = isolate->strict_compilation();
-  } else {
-    checkedFlag = checked.value();
+  IsolateSpawnState* state = new IsolateSpawnState(port.Id(),
+                                                   canonical_uri,
+                                                   utf8_package_root,
+                                                   args,
+                                                   message,
+                                                   paused.value());
+  // If we were passed a value then override the default flags state for
+  // checked mode.
+  if (!checked.IsNull()) {
+    state->isolate_flags()->set_checked(checked.value());
   }
 
-  Spawn(isolate, new IsolateSpawnState(port.Id(),
-                                       canonical_uri,
-                                       utf8_package_root,
-                                       args,
-                                       message,
-                                       paused.value(),
-                                       checkedFlag));
+  Spawn(isolate, state);
   return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Isolate_getPortAndCapabilitiesOfCurrentIsolate, 0) {
   const Array& result = Array::Handle(Array::New(3));
   result.SetAt(0, SendPort::Handle(SendPort::New(isolate->main_port())));
   result.SetAt(1, Capability::Handle(
                       Capability::New(isolate->pause_capability())));
   result.SetAt(2, Capability::Handle(
@@ skipping 13 matching lines @@
   MessageWriter writer(&data, &allocator, false);
   writer.WriteMessage(msg);
 
   PortMap::PostMessage(new Message(port.Id(),
                                    data, writer.BytesWritten(),
                                    Message::kOOBPriority));
   return Object::null();
 }
 
 }  // namespace dart