Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 1162033002: Introduce RenderProxyBox and RenderSizedBox (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Introduce RenderProxyBox and RenderSizedBox Also makes Point, Size, and Rect immutable. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/356b14d61b43c99d2bd8e3aaa270d89096ef9db0

Patch Set 1 #

Patch Set 2 : Now with test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -49 lines) Patch
M sky/engine/core/painting/Point.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/painting/Rect.dart View 2 chunks +5 lines, -9 lines 0 comments Download
M sky/engine/core/painting/Size.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/examples/raw/sector-layout.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/raw/simple_render_tree.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sky/examples/raw/spinning_square.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/spinning_arabic.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 1 5 chunks +51 lines, -7 lines 0 comments Download
M sky/tests/raw/render_box.dart View 1 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-05-28 20:13:28 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-05-28 20:38:54 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-05-28 20:39:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
356b14d61b43c99d2bd8e3aaa270d89096ef9db0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698