Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1162023010: Don't crash when removing a radio button (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson_old, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't crash when removing a radio button We were hitting an assert in RenderCustomPaint that the callback wasn't null. R=eseidel@chromium.org, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7c4fce5046d77b602aca85b8263e7235965364b7

Patch Set 1 #

Patch Set 2 : more asserts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M sky/sdk/lib/framework/rendering/box.dart View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-05 17:23:14 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-05 17:34:29 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-05 19:17:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c4fce5046d77b602aca85b8263e7235965364b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698