Chromium Code Reviews| Index: sky/engine/core/painting/Color.dart |
| diff --git a/sky/engine/core/painting/Color.dart b/sky/engine/core/painting/Color.dart |
| index b88e3b45619e84bac46be5ead6773ac2e3a20fcc..d487d0a444a3efa3a3db6b178b7a11bace94bf7a 100644 |
| --- a/sky/engine/core/painting/Color.dart |
| +++ b/sky/engine/core/painting/Color.dart |
| @@ -8,6 +8,12 @@ class Color { |
| final int _value; |
| int get value => _value; |
| + static const Color black = const Color(0xFF000000); |
|
eseidel
2015/06/03 19:32:20
I wouldn't build these into colors, but rather on
Matt Perry
2015/06/03 20:17:01
Done.
|
| + static const Color white = const Color(0xFFFFFFFF); |
| + static const Color red = const Color(0xFFFF0000); |
| + static const Color green = const Color(0xFF00FF00); |
| + static const Color blue = const Color(0xFF0000FF); |
|
Hixie
2015/06/03 19:35:10
I don't think we should name colours.
It's ok if t
Matt Perry
2015/06/03 20:17:01
Done.
|
| + |
| const Color(this._value); |
| const Color.fromARGB(int a, int r, int g, int b) : |
| _value = (((a & 0xff) << 24) | |
| @@ -15,4 +21,12 @@ class Color { |
| ((g & 0xff) << 8) | |
| ((b & 0xff) << 0)); |
| + bool operator ==(other) { |
| + if (!(other is Color)) return false; |
| + return _value == other._value; |
| + } |
|
Hixie
2015/06/03 19:35:11
bool operator == (other) => other is Color && _val
Matt Perry
2015/06/03 20:17:01
Done.
|
| + int get hashCode { |
| + return _value.hashCode; |
| + } |
|
Hixie
2015/06/03 19:35:11
int get hashCode => _value.hashCode;
Matt Perry
2015/06/03 20:17:01
Done.
|
| + String toString() => "Color($_value)"; |
|
kulakowski
2015/06/03 19:29:52
"Color(0x${_value.toRadixString(16)})"
might be n
Hixie
2015/06/03 19:35:11
String toString() => "Color(0x${_value.toRadixStri
Matt Perry
2015/06/03 20:17:01
Awesome, thanks. Done.
Are you OK with the Paint.
|
| } |