associate @deprecated with enum element

pkg/analyzer/test/generated/element_test.dart

Index: pkg/analyzer/test/generated/element_test.dart
diff --git a/pkg/analyzer/test/generated/element_test.dart b/pkg/analyzer/test/generated/element_test.dart
index b52ddee2fa9de160ab116c3f21e4d985b03aec80..09b96d5aea5ca40c2f57ce58d573bfebdd0e8806 100644
--- a/pkg/analyzer/test/generated/element_test.dart
+++ b/pkg/analyzer/test/generated/element_test.dart
@@ -48,14 +48,17 @@ class ClassElementImplTest extends EngineTestCase {
     AnalysisContext context = contextHelper.context;
     Source source = contextHelper.addSource("/test.dart", r'''
 class A {}
-class B {}
-enum C {C1, C2, C3}''');
+@deprecated class B {}
+enum C {C1, C2, C3}
+@deprecated enum D {D1, D2, D3}''');
     // prepare CompilationUnitElement
     LibraryElement libraryElement = context.computeLibraryElement(source);
     CompilationUnitElement unitElement = libraryElement.definingCompilationUnit;
     // A
     {
       ClassElement elementA = unitElement.getType("A");
+      expect(elementA.isDeprecated, isFalse);

[scheglov, 2015/06/05 15:08:37]

This test is not an appropriate place to test isEnum or isDeprecated.
It is for computeNode().
I think we need to add a new test.

[Brian Wilkerson, 2015/06/05 15:14:33]

I disagree. Most of our test classes test the full behavior of a single class;
we write a FooTest class to contain the tests for the Foo class. This class is
ClassElementImplTest, so I would expect it to test all of the behavior of
ClassElementImpl. I think it's an historic accident that the only behavior of
the element classes that's being tested is computeNode and that it's fine to
extend these tests to cover more of the element model's behavior.

If you're suggesting that we change the way our tests are organized, then I
think an e-mail thread would be a better place to discuss it.

+      expect(elementA.isEnum, isFalse);
       ClassDeclaration nodeA = elementA.computeNode();
       expect(nodeA, isNotNull);
       expect(nodeA.name.name, "A");
@@ -64,6 +67,8 @@ enum C {C1, C2, C3}''');
     // B
     {
       ClassElement elementB = unitElement.getType("B");
+      expect(elementB.isDeprecated, isTrue);
+      expect(elementB.isEnum, isFalse);
       ClassDeclaration nodeB = elementB.computeNode();
       expect(nodeB, isNotNull);
       expect(nodeB.name.name, "B");
@@ -72,11 +77,23 @@ enum C {C1, C2, C3}''');
     // C
     {
       ClassElement elementC = unitElement.getEnum("C");
+      expect(elementC.isDeprecated, isFalse);
+      expect(elementC.isEnum, isTrue);
       EnumDeclaration nodeC = elementC.computeNode();
       expect(nodeC, isNotNull);
       expect(nodeC.name.name, "C");
       expect(nodeC.element, same(elementC));
     }
+    // D
+    {
+      ClassElement elementD = unitElement.getEnum("D");
+      expect(elementD.isDeprecated, isTrue);
+      expect(elementD.isEnum, isTrue);
+      EnumDeclaration nodeC = elementD.computeNode();
+      expect(nodeC, isNotNull);
+      expect(nodeC.name.name, "D");
+      expect(nodeC.element, same(elementD));
+    }
   }
 
   void test_computeNode_ClassTypeAlias() {