Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1162013003: Merge to XFA: Fix ALL the include guards. (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Re-upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+668 lines, -618 lines) Patch
M core/include/fdrm/fx_crypt.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 2 chunks +6 lines, -5 lines 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 2 chunks +6 lines, -5 lines 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 2 chunks +7 lines, -10 lines 0 comments Download
M core/include/fpdfapi/fpdf_pageobj.h View 2 chunks +7 lines, -8 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +6 lines, -7 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 2 chunks +7 lines, -8 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 2 chunks +7 lines, -8 lines 0 comments Download
M core/include/fpdfapi/fpdf_serial.h View 2 chunks +6 lines, -7 lines 0 comments Download
M core/include/fpdfapi/fpdfapi.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 2 chunks +6 lines, -7 lines 0 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fpdftext/fpdf_text.h View 2 chunks +8 lines, -11 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 2 chunks +6 lines, -5 lines 0 comments Download
M core/include/fxcodec/fx_codec_def.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/include/fxcodec/fx_codec_provider.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_arb.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_coordinates.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 2 chunks +5 lines, -4 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_string.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_ucd.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_xml.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fxge/fpf.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/include/fxge/fx_dib.h View 2 chunks +6 lines, -5 lines 0 comments Download
M core/include/fxge/fx_font.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/fxge/fx_freetype.h View 2 chunks +5 lines, -0 lines 0 comments Download
M core/include/fxge/fx_ge.h View 3 chunks +7 lines, -7 lines 0 comments Download
M core/include/fxge/fx_ge_apple.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/include/fxge/fx_ge_win32.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/include/reflow/fpdf_layout.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/reflow/reflowengine.h View 2 chunks +8 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/cmap_int.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/editint.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/common.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 2 chunks +4 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/filters_int.h View 2 chunks +5 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 2 chunks +6 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/src/fpdftext/text_int.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdftext/txtproc.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fx_jpeglib.h View 1 chunk +6 lines, -4 lines 0 comments Download
M core/src/fx_zlib.h View 1 chunk +6 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/include/fx_openjpeg.h View 1 chunk +6 lines, -3 lines 0 comments Download
M core/src/fxcodec/fx_zlib/include/fx_zlib.h View 1 chunk +5 lines, -0 lines 0 comments Download
M core/src/fxcodec/lcms2/include/fx_lcms2.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxcodec/lcms2/include/fx_lcms2_plugin.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxcrt/extension.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_arabic.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_safe_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/fxcrt/fxcrt_posix.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/fxcrt/fxcrt_windows.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/fxcrt/plex.h View 2 chunks +4 lines, -0 lines 0 comments Download
M core/src/fxcrt/xml_int.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_basics.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_clip_liang_barsky.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_conv_dash.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_conv_stroke.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_curves.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_path_storage.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_rasterizer_scanline_aa.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_renderer_scanline.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_rendering_buffer.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/agg/include/fxfx_agg_scanline_u.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/android/fx_android_font.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/android/fx_fpf.h View 1 chunk +7 lines, -5 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/dib/dib_int.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.h View 2 chunks +5 lines, -4 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.h View 2 chunks +6 lines, -5 lines 0 comments Download
M core/src/fxge/win32/dwrite_int.h View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fxge/win32/win32_int.h View 2 chunks +4 lines, -0 lines 0 comments Download
M core/src/reflow/autoreflow.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/reflow/layoutprovider_taggedpdf.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/reflow/reflowedpage.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/reflow/reflowedtextpage.h View 2 chunks +6 lines, -3 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_CheckBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ListBox.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_Notify.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_PushButton.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_RadioButton.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_TextField.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_Utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/formfiller/FormFiller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 2 chunks +3 lines, -6 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 2 chunks +3 lines, -6 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_common.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_stub.h View 1 chunk +8 lines, -18 lines 0 comments Download
M fpdfsdk/include/javascript/Consts.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/Field.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Context.h View 2 chunks +3 lines, -11 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_EventHandler.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_GlobalData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 2 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/include/javascript/JavaScript.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/console.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/event.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/util.h View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/IPDFWindow.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Button.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Caret.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 2 chunks +3 lines, -27 lines 0 comments Download
M fpdfsdk/src/resource.h View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR
5 years, 6 months ago (2015-05-28 20:23:03 UTC) #1
Tom Sepez
Committed patchset #2 (id:20001) manually as 19922bbc0d62b81e0fdd6a01da39e9b875c53c68 (presubmit successful).
5 years, 6 months ago (2015-05-28 20:23:16 UTC) #2
Lei Zhang
5 years, 6 months ago (2015-05-28 20:26:16 UTC) #3
Message was sent while issue was closed. 
spot check lgtm

Powered by Google App Engine
This is Rietveld 408576698