[Profiles, Fixit] Making GAIAInfoUpdateService into a ProfileKeyedService.

chrome/browser/profiles/gaia_info_update_service_factory.h

Index: chrome/browser/profiles/gaia_info_update_service_factory.h
diff --git a/chrome/browser/profiles/gaia_info_update_service_factory.h b/chrome/browser/profiles/gaia_info_update_service_factory.h
new file mode 100755
index 0000000000000000000000000000000000000000..8676d00ef41302db7b8f4b0009a6ad9a16597b03
--- /dev/null
+++ b/chrome/browser/profiles/gaia_info_update_service_factory.h
@@ -0,0 +1,43 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PROFILES_GAIA_INFO_UPDATE_SERVICE_FACTORY_H_
+#define CHROME_BROWSER_PROFILES_GAIA_INFO_UPDATE_SERVICE_FACTORY_H_
+
+#include "base/memory/singleton.h"
+#include "chrome/browser/profiles/profile_keyed_service_factory.h"
+
+class GAIAInfoUpdateService;
+class Profile;
+
+// Singleton that owns all GAIAInfoUpdateServices and associates them with
+// Profiles. Listens for the Profile's destruction notification and cleans up
+// the associated GAIAInfoUpdateService.
+class GAIAInfoUpdateServiceFactory : public ProfileKeyedServiceFactory {
+ public:
+  // Returns the instance of GAIAInfoUpdateService associated with this profile
+  // (creating one if none exists). Returns NULL if this profile cannot have a
+  // GAIAInfoUpdateService (for example, if |profile| is incognito).
+  static GAIAInfoUpdateService* GetForProfile(Profile* profile);
+
+  // Returns an instance of the GAIAInfoUpdateServiceFactory singleton.
+  static GAIAInfoUpdateServiceFactory* GetInstance();
+
+ private:
+  friend struct DefaultSingletonTraits<GAIAInfoUpdateServiceFactory>;
+
+  GAIAInfoUpdateServiceFactory();
+  virtual ~GAIAInfoUpdateServiceFactory();
+
+  // ProfileKeyedServiceFactory:
+  virtual ProfileKeyedService* BuildServiceInstanceFor(
+      Profile* profile) const OVERRIDE;
+
+  virtual void RegisterUserPrefs(PrefService* prefs) OVERRIDE;
+  virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;

[Bernhard Bauer, 2012/12/18 07:37:49]

Hm, I think you need to override ServiceIsCreatedWithProfile() as well to return
true, otherwise the GAIAInfoUpdateService is never actually instantiated.

[rpetterson, 2012/12/18 08:44:59]

I intentionally didn't figuring that it would get created when it was needed --
I couldn't find anywhere that it was used that couldn't create it on the fly.
Sail would probably know for sure though. Sail?

[Bernhard Bauer, 2012/12/18 14:15:30]

Well, I couldn't find anymore that it was used, period ;-) I think what happens
in the old version is that it is created with the profile and then starts
updating, but it's never used by something else, so with lazy creation it
wouldn't get created at all.

+
+  DISALLOW_COPY_AND_ASSIGN(GAIAInfoUpdateServiceFactory);
+};
+
+#endif  // CHROME_BROWSER_PROFILES_GAIA_INFO_UPDATE_SERVICE_FACTORY_H_