Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: net/url_request/url_request_throttler_unittest.cc

Issue 11620007: Switch from OnIPAddressChanged and OnConnectionTypeChange to OnNetworkChanged Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_throttler_unittest.cc
diff --git a/net/url_request/url_request_throttler_unittest.cc b/net/url_request/url_request_throttler_unittest.cc
index 221d0c8788a1d1f0df7524dfd9e1dac45d976bfb..fd6b6aa84e58c9a4c1ac2506a12626878aeb3ccd 100644
--- a/net/url_request/url_request_throttler_unittest.cc
+++ b/net/url_request/url_request_throttler_unittest.cc
@@ -527,37 +527,25 @@ TEST_F(URLRequestThrottlerManagerTest, OptOutHeader) {
}
TEST_F(URLRequestThrottlerManagerTest, ClearOnNetworkChange) {
- for (int i = 0; i < 3; ++i) {
- MockURLRequestThrottlerManager manager;
- scoped_refptr<net::URLRequestThrottlerEntryInterface> entry_before =
- manager.RegisterRequestUrl(GURL("http://www.example.com/"));
- MockURLRequestThrottlerHeaderAdapter failure_adapter(503);
- for (int j = 0; j < 10; ++j) {
- // Host doesn't really matter in this scenario so we skip it.
- entry_before->UpdateWithResponse("", &failure_adapter);
- }
- EXPECT_TRUE(entry_before->ShouldRejectRequest(request_));
-
- switch (i) {
- case 0:
- manager.OnIPAddressChanged();
- break;
- case 1:
- manager.OnConnectionTypeChanged(
- net::NetworkChangeNotifier::CONNECTION_UNKNOWN);
- break;
- case 2:
- manager.OnConnectionTypeChanged(
- net::NetworkChangeNotifier::CONNECTION_NONE);
- break;
- default:
- FAIL();
- }
-
- scoped_refptr<net::URLRequestThrottlerEntryInterface> entry_after =
- manager.RegisterRequestUrl(GURL("http://www.example.com/"));
- EXPECT_FALSE(entry_after->ShouldRejectRequest(request_));
+ MockURLRequestThrottlerManager manager;
+ scoped_refptr<net::URLRequestThrottlerEntryInterface> entry_before =
+ manager.RegisterRequestUrl(GURL("http://www.example.com/"));
+ MockURLRequestThrottlerHeaderAdapter failure_adapter(503);
+ for (int j = 0; j < 10; ++j) {
+ // Host doesn't really matter in this scenario so we skip it.
+ entry_before->UpdateWithResponse("", &failure_adapter);
}
+ EXPECT_TRUE(entry_before->ShouldRejectRequest(request_));
+
+ manager.OnNetworkChanged(net::NetworkChangeNotifier::CONNECTION_UNKNOWN);
+ scoped_refptr<net::URLRequestThrottlerEntryInterface> first_entry_after =
+ manager.RegisterRequestUrl(GURL("http://www.example.com/"));
+ EXPECT_TRUE(first_entry_after->ShouldRejectRequest(request_));
+
+ manager.OnNetworkChanged(net::NetworkChangeNotifier::CONNECTION_NONE);
+ scoped_refptr<net::URLRequestThrottlerEntryInterface> second_entry_after =
+ manager.RegisterRequestUrl(GURL("http://www.example.com/"));
+ EXPECT_FALSE(second_entry_after->ShouldRejectRequest(request_));
}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698