Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 11620007: Switch from OnIPAddressChanged and OnConnectionTypeChange to OnNetworkChanged Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base.cc
diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc
index 7a029093127cbf113f7ebbb11df5c0cb0749cc86..f37ab2b1a9470f17d615037d0db394fb4e79fd1a 100644
--- a/net/socket/client_socket_pool_base.cc
+++ b/net/socket/client_socket_pool_base.cc
@@ -184,7 +184,7 @@ ClientSocketPoolBaseHelper::ClientSocketPoolBaseHelper(
DCHECK_LE(0, max_sockets_per_group);
DCHECK_LE(max_sockets_per_group, max_sockets);
- NetworkChangeNotifier::AddIPAddressObserver(this);
+ NetworkChangeNotifier::AddNetworkChangeObserver(this);
}
ClientSocketPoolBaseHelper::~ClientSocketPoolBaseHelper() {
@@ -197,7 +197,7 @@ ClientSocketPoolBaseHelper::~ClientSocketPoolBaseHelper() {
DCHECK_EQ(0, connecting_socket_count_);
CHECK(higher_layer_pools_.empty());
- NetworkChangeNotifier::RemoveIPAddressObserver(this);
+ NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
}
ClientSocketPoolBaseHelper::CallbackResultPair::CallbackResultPair()
@@ -910,8 +910,10 @@ void ClientSocketPoolBaseHelper::OnConnectJobComplete(
}
}
-void ClientSocketPoolBaseHelper::OnIPAddressChanged() {
- FlushWithError(ERR_NETWORK_CHANGED);
+void ClientSocketPoolBaseHelper::OnNetworkChanged(
+ net::NetworkChangeNotifier::ConnectionType type) {
+ if (type == net::NetworkChangeNotifier::CONNECTION_NONE)
+ FlushWithError(ERR_NETWORK_CHANGED);
}
void ClientSocketPoolBaseHelper::FlushWithError(int error) {

Powered by Google App Engine
This is Rietveld 408576698