Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4205)

Unified Diff: chrome/browser/net/dns_probe_service.cc

Issue 11620007: Switch from OnIPAddressChanged and OnConnectionTypeChange to OnNetworkChanged Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/dns_probe_service.cc
diff --git a/chrome/browser/net/dns_probe_service.cc b/chrome/browser/net/dns_probe_service.cc
index 7b12d72c4b4d857ea8f612129a4cf892c8f7f017..c380d15eb43c9e25b301ccc4ff54717988087dc9 100644
--- a/chrome/browser/net/dns_probe_service.cc
+++ b/chrome/browser/net/dns_probe_service.cc
@@ -78,11 +78,11 @@ DnsProbeService::DnsProbeService()
state_(STATE_NO_RESULTS),
result_(chrome_common_net::DNS_PROBE_UNKNOWN),
dns_attempts_(GetAttemptsFromFieldTrial()) {
- NetworkChangeNotifier::AddIPAddressObserver(this);
+ NetworkChangeNotifier::AddNetworkChangeObserver(this);
}
DnsProbeService::~DnsProbeService() {
- NetworkChangeNotifier::RemoveIPAddressObserver(this);
+ NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
}
void DnsProbeService::ProbeDns(const DnsProbeService::CallbackType& callback) {
@@ -118,8 +118,10 @@ scoped_ptr<DnsProbeJob> DnsProbeService::CreatePublicProbeJob(
return CreateProbeJob(public_config, job_callback);
}
-void DnsProbeService::OnIPAddressChanged() {
- if (state_ == STATE_RESULTS_CACHED)
+void DnsProbeService::OnNetworkChanged(
+ net::NetworkChangeNotifier::ConnectionType type) {
+ if (type == net::NetworkChangeNotifier::CONNECTION_NONE &&
+ state_ == STATE_RESULTS_CACHED)
ExpireResults();
}

Powered by Google App Engine
This is Rietveld 408576698