Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: PRESUBMIT.py

Issue 1161973005: Presubmit: add PRESUBMIT=false to non-master branch changes (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 6d429dfa1c1ac4116763e36b75641bede6189b45..51c5bf1e79ef031aca2ffe73ca0aa8e90851c390 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -343,6 +343,7 @@ def PostUploadHook(cl, change, output_api):
need to be gated on the master branch's tree.
* Adds 'NOTRY=true' for non master branch changes since trybots do not yet
work on them.
+ * Adds 'NOPRESUBMIT=true' for non master branch changes since
rmistry 2015/06/04 17:18:29 missing the rest of this sentence
borenet 2015/06/04 17:26:57 Yeah... why don't we run presubmit for changes on
rmistry 2015/06/04 17:28:53 Because presubmit is now a trybot and trybots dont
"""
results = []
@@ -405,6 +406,12 @@ def PostUploadHook(cl, change, output_api):
output_api.PresubmitNotifyResult(
'Trybots do not yet work for non-master branches. '
'Automatically added \'NOTRY=true\' to the CL\'s description'))
+ if not re.search(
+ r'^NOPRESUBMIT=true$', new_description, re.M | re.I):
+ new_description += "\nNOTREECHECKS=true"
rmistry 2015/06/04 17:18:29 NOTREECHECKS -> NOPRESUBMIT
borenet 2015/06/04 17:26:57 Whoops, did this too quickly.
+ results.append(
+ output_api.PresubmitNotifyResult(
+ 'Branch changes do not run the presubmit checks.'))
# Read and process the HASHTAGS file.
hashtags_fullpath = os.path.join(change._local_root, 'HASHTAGS')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698