Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161973005: Presubmit: add PRESUBMIT=false to non-master branch changes (Closed)

Created:
5 years, 6 months ago by borenet
Modified:
5 years, 6 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Presubmit: add PRESUBMIT=false to non-master branch changes BUG=skia: Committed: https://skia.googlesource.com/skia/+/af6005c8a20cea18d515f55b9f5bb1ee8e8b6833

Patch Set 1 #

Total comments: 5

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
borenet
5 years, 6 months ago (2015-06-04 17:16:42 UTC) #2
rmistry
https://codereview.chromium.org/1161973005/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1161973005/diff/1/PRESUBMIT.py#newcode346 PRESUBMIT.py:346: * Adds 'NOPRESUBMIT=true' for non master branch changes since ...
5 years, 6 months ago (2015-06-04 17:18:29 UTC) #3
borenet
https://codereview.chromium.org/1161973005/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1161973005/diff/1/PRESUBMIT.py#newcode346 PRESUBMIT.py:346: * Adds 'NOPRESUBMIT=true' for non master branch changes since ...
5 years, 6 months ago (2015-06-04 17:26:57 UTC) #4
rmistry
https://codereview.chromium.org/1161973005/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1161973005/diff/1/PRESUBMIT.py#newcode346 PRESUBMIT.py:346: * Adds 'NOPRESUBMIT=true' for non master branch changes since ...
5 years, 6 months ago (2015-06-04 17:28:53 UTC) #5
rmistry
lgtm
5 years, 6 months ago (2015-06-04 17:28:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161973005/20001
5 years, 6 months ago (2015-06-04 20:32:20 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 22:15:47 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/af6005c8a20cea18d515f55b9f5bb1ee8e8b6833

Powered by Google App Engine
This is Rietveld 408576698