Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' …

Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' link button.

BUG=491011
Committed: https://crrev.com/414d005380ea200ea9422edd650634b377a8beea
Cr-Commit-Position: refs/heads/master@{#333130}

[gogerald1, 2015-05-28 14:34:13]

gogerald@chromium.org changed reviewers:
+ groby@chromium.org, rogerta@chromium.org

[gogerald1, 2015-05-28 14:35:38]

Update for the regression described in title, please help review it.

[Roger Tawa OOO till Jul 10th, 2015-05-28 14:55:38]

lgtm

Thanks Ganggui.

[groby-ooo-7-16, 2015-05-28 17:45:29]

This seems not the right way to fix this.

If I understand the code correctly, this sets "close on deactivate", then hopes
that something triggers a deactivate event. Why not simply close instead?

[gogerald1, 2015-05-28 18:25:18]

On 2015/05/28 17:45:29, groby wrote:
> This seems not the right way to fix this.
> 
> If I understand the code correctly, this sets "close on deactivate", then
hopes
> that something triggers a deactivate event. Why not simply close instead?

Hi Groby, This cl is a correction of the previous cl
(https://codereview.chromium.org/1136693002/). In the previous cl, we set close
on deactivate false to keep the bubble view open in some views as we expect, but
we forgot to set it back to let the bubble view go away right before user
clicked "settings" (what I do in this cl). Before the previous cl, the bubble
review get closed because of lose of focus after user clicked "settings".

[groby-ooo-7-16, 2015-05-29 20:26:41]

Yes :)

What I'm saying is that instead of relying on the focus loss to close, this CL
should _explicitly_ close the bubble on click, since that's the desired
behavior.

I.e. [self close]; 

That is assuming that  SyncConfirmationUIClosed will actually invoke the sync
settings. Am I misunderstanding something?

[gogerald1, 2015-06-01 20:21:56]

Close bubble view when user clicked on setting to switch to full tab page, as
"Need Help" and "Create an account". Please review it.

[Roger Tawa OOO till Jul 10th, 2015-06-04 17:09:33]

still lgtm

[groby-ooo-7-16, 2015-06-04 17:38:50]

lgtm

[gogerald1, 2015-06-04 18:41:26]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2015-06-04 18:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161973002/20001

[commit-bot: I haz the power, 2015-06-04 18:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 18:52:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gogerald1, 2015-06-04 19:28:38]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2015-06-04 19:28:38]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1161973002/#ps40001
(title: "rebase before landing")

[commit-bot: I haz the power, 2015-06-04 19:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161973002/40001

[commit-bot: I haz the power, 2015-06-04 19:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 19:39:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gogerald1, 2015-06-04 20:17:52]

gogerald@chromium.org changed reviewers:
+ msw@chromium.org

[gogerald1, 2015-06-04 20:17:53]

Hi, Mike, Could you help me review this CL.

[msw, 2015-06-05 19:51:48]

lgtm with a nit

https://codereview.chromium.org/1161973002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/1161973002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:875:
profile_bubble_->Hide();
nit: Just call Hide() (the static ProfileChooserView::Hide())

[gogerald1, 2015-06-05 20:15:06]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2015-06-05 20:15:06]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
rogerta@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1161973002/#ps60001
(title: "address msw's comments")

[commit-bot: I haz the power, 2015-06-05 20:16:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161973002/60001

[commit-bot: I haz the power, 2015-06-05 21:06:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-05 21:07:37]

Patchset 4 (id:??) landed as
https://crrev.com/414d005380ea200ea9422edd650634b377a8beea
Cr-Commit-Position: refs/heads/master@{#333130}

[gogerald1, 2015-07-14 14:15:10]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1237123002/ by gogerald@chromium.org.

The reason for reverting is: This CL reveals issues can not be solved
immediately, so we revert it to allow time to solve them or find alternative
solutions..