Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: Source/core/css/parser/CSSParserToken.cpp

Issue 1161963002: Shrinking CSSParserToken for lower CSS parsing memory usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSParserToken.cpp
diff --git a/Source/core/css/parser/CSSParserToken.cpp b/Source/core/css/parser/CSSParserToken.cpp
index 747c61aa685a23686ee0acd6fecc4add0d4a5887..5ac3d2cbf4d2ed44fa1fa9fd95e8cbb01c671b86 100644
--- a/Source/core/css/parser/CSSParserToken.cpp
+++ b/Source/core/css/parser/CSSParserToken.cpp
@@ -31,8 +31,8 @@ CSSParserToken::CSSParserToken(CSSParserTokenType type, UChar c)
CSSParserToken::CSSParserToken(CSSParserTokenType type, CSSParserString value, BlockType blockType)
: m_type(type)
, m_blockType(blockType)
- , m_value(value)
{
+ initValueFromCSSParserString(value);
}
CSSParserToken::CSSParserToken(CSSParserTokenType type, double numericValue, NumericValueType numericValueType, NumericSign sign)
@@ -58,16 +58,16 @@ CSSParserToken::CSSParserToken(CSSParserTokenType type, UChar32 start, UChar32 e
CSSParserToken::CSSParserToken(HashTokenType type, CSSParserString value)
: m_type(HashToken)
, m_blockType(NotBlock)
- , m_value(value)
, m_hashTokenType(type)
{
+ initValueFromCSSParserString(value);
}
void CSSParserToken::convertToDimensionWithUnit(CSSParserString unit)
{
ASSERT(m_type == NumberToken);
m_type = DimensionToken;
- m_value = unit;
+ initValueFromCSSParserString(unit);
m_unit = CSSPrimitiveValue::fromName(unit);
}
@@ -107,7 +107,7 @@ double CSSParserToken::numericValue() const
CSSPropertyID CSSParserToken::parseAsUnresolvedCSSPropertyID() const
{
ASSERT(m_type == IdentToken);
- return unresolvedCSSPropertyID(m_value);
+ return unresolvedCSSPropertyID(value());
}
void CSSParserToken::serialize(StringBuilder& builder) const

Powered by Google App Engine
This is Rietveld 408576698