Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

Issue 1161953003: [tracing] Change outer/inner size repr. in memory dumps (blink side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: WAR string + operator overload Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/PartitionAllocMemoryDumpProvider.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
diff --git a/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp b/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
index 7db5047e1e7f5b82101318b4ab4bb99047ba2e7c..9878d7c1f370bac505c6f9c69a809dfe99295691 100644
--- a/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
+++ b/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
@@ -21,9 +21,12 @@ BlinkGCMemoryDumpProvider* BlinkGCMemoryDumpProvider::instance()
bool BlinkGCMemoryDumpProvider::onMemoryDump(blink::WebProcessMemoryDump* memoryDump)
{
WebMemoryAllocatorDump* allocatorDump = memoryDump->createMemoryAllocatorDump("blink_gc");
- allocatorDump->AddScalar("inner_size", "bytes", Heap::allocatedObjectSize());
- allocatorDump->AddScalar("outer_size", "bytes", Heap::allocatedSpace());
- allocatorDump->AddScalar("estimated_live_object_size", "bytes", Heap::estimatedLiveObjectSize());
+ allocatorDump->AddScalar("size", "bytes", Heap::allocatedSpace());
+
+ WebMemoryAllocatorDump* objectsDump = memoryDump->createMemoryAllocatorDump("blink_gc/allocated_objects");
+ objectsDump->AddScalar("size", "bytes", Heap::allocatedObjectSize());
+ objectsDump->AddScalar("estimated_live_object_size", "bytes", Heap::estimatedLiveObjectSize());
+
return true;
}
« no previous file with comments | « Source/platform/PartitionAllocMemoryDumpProvider.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698