Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(44)

Issue 1161953003: [tracing] Change outer/inner size repr. in memory dumps (blink side) (Closed)

Created:
4 years, 11 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
haraken, ssid
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Change outer/inner size repr. in memory dumps (blink side) This CL complements the chromium side crrev.com/1150473004. This is just getting rid of the confusing outer_size and inner_size names in favour of just a "size" (which will become the default value understood by the infrastructure). Furthermore this will make the trace viewer UI in a better position when it comes to understand allocator efficiency / overhead (by just comparing the sizes of nested dumps, instead of having to know magical names). BUG=495002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196409

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : WAR string + operator overload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Primiano Tucci (use gerrit)
Very small change, but makes the dumps less confusing...nobody could get outer/inner so we're just ...
4 years, 11 months ago (2015-06-02 11:45:52 UTC) #2
haraken
LGTM
4 years, 11 months ago (2015-06-02 13:17:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161953003/40001
4 years, 11 months ago (2015-06-03 14:16:26 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 15:51:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196409

Powered by Google App Engine
This is Rietveld 408576698