Roll android_tools library.

Roll android_tools library.

- Android SDK tools 24.1.2 -> 24.3
- Android Support Library 22.1 -> 22.2
- Modify ctype.h headers to test for non-GNU inline semantics correctly
- Upgrade Android NDK to r10e.

BUG=None

Committed: https://crrev.com/a9d97645e8bfbf0b60fd667a504f2740aadc553f
Cr-Commit-Position: refs/heads/master@{#332323}

[aurimas (slooooooooow), 2015-05-29 18:52:46]

aurimas@chromium.org changed reviewers:
+ newt@chromium.org, pcc@chromium.org

[aurimas (slooooooooow), 2015-05-29 18:52:47]

PTAL

[newt (away), 2015-05-29 19:21:29]

Bumping the SDK tools and support library versions looks good to me.

I'll defer to pcc@ to verify if the ctypes.h change is safe to roll in.

[pcc1, 2015-05-29 19:22:37]

On 2015/05/29 19:21:29, newt wrote:
> Bumping the SDK tools and support library versions looks good to me.
> 
> I'll defer to pcc@ to verify if the ctypes.h change is safe to roll in.

Rolling in the ctype.h change LGTM.

[aurimas (slooooooooow), 2015-05-29 19:55:12]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-05-29 19:55:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/1

[commit-bot: I haz the power, 2015-05-29 19:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 19:55:35]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[newt (away), 2015-05-29 19:56:27]

lgtm

[aurimas (slooooooooow), 2015-05-29 20:15:12]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-05-29 20:16:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/1

[commit-bot: I haz the power, 2015-05-30 00:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-30 00:03:18]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-05-30 00:54:50]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-05-30 00:54:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/1

[commit-bot: I haz the power, 2015-05-30 03:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-30 03:43:09]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-05-30 21:20:16]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-05-30 21:20:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/1

[commit-bot: I haz the power, 2015-05-30 23:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-30 23:44:19]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-06-01 19:56:50]

I cannot roll the library I did not update gyp correctly to include newly added
res/ in recyclerview library.

CL: https://chromium-review.googlesource.com/#/c/274412/1

[aurimas (slooooooooow), 2015-06-01 20:26:45]

aurimas@chromium.org changed reviewers:
+ cjhopman@chromium.org, fdegans@chromium.org

[aurimas (slooooooooow), 2015-06-01 20:26:46]

+cjhopman for GN changes.
+fdegans for NDK roll

[aurimas (slooooooooow), 2015-06-01 20:26:58]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[aurimas (slooooooooow), 2015-06-01 20:26:58]

The patchset sent to the CQ was uploaded after l-g-t-m from pcc@chromium.org,
newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1161933005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-01 20:29:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/40001

[Fabrice (no longer in Chrome), 2015-06-01 20:35:37]

lgtm, trybots should find potentiel issues.
I'm sheriff tomorrow anyway, I'll fix the rest myself if needed.

[commit-bot: I haz the power, 2015-06-01 20:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 20:42:07]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[aurimas (slooooooooow), 2015-06-01 20:44:59]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[aurimas (slooooooooow), 2015-06-01 20:44:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
fdegans@chromium.org, pcc@chromium.org, newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1161933005/#ps60001
(title: "Fix GN builds")

[commit-bot: I haz the power, 2015-06-01 20:45:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/60001

[cjhopman, 2015-06-01 20:48:36]

https://chromiumcodereview.appspot.com/1161933005/diff/60001/build/secondary/...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1161933005/diff/60001/build/secondary/...
build/secondary/third_party/android_tools/BUILD.gn:77:
":android_support_v7_appcompat_java",
This should depend on the _resources target. Then things that depend on the
_java get the required resources (things that explicitly need the resources can
depend on the _resources).

https://chromiumcodereview.appspot.com/1161933005/diff/60001/chrome/android/B...
File chrome/android/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1161933005/diff/60001/chrome/android/B...
chrome/android/BUILD.gn:608:
"//third_party/android_tools:android_support_v7_recyclerview_resources",
With other change, this shouldn't be needed.

[aurimas (slooooooooow), 2015-06-01 20:54:44]

https://chromiumcodereview.appspot.com/1161933005/diff/60001/build/secondary/...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1161933005/diff/60001/build/secondary/...
build/secondary/third_party/android_tools/BUILD.gn:77:
":android_support_v7_appcompat_java",
On 2015/06/01 at 20:48:36, cjhopman wrote:
> This should depend on the _resources target. Then things that depend on the
_java get the required resources (things that explicitly need the resources can
depend on the _resources).

Done

https://chromiumcodereview.appspot.com/1161933005/diff/60001/chrome/android/B...
File chrome/android/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1161933005/diff/60001/chrome/android/B...
chrome/android/BUILD.gn:608:
"//third_party/android_tools:android_support_v7_recyclerview_resources",
On 2015/06/01 at 20:48:36, cjhopman wrote:
> With other change, this shouldn't be needed.

Done

[cjhopman, 2015-06-01 22:06:52]

lgtm

https://chromiumcodereview.appspot.com/1161933005/diff/80001/build/secondary/...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1161933005/diff/80001/build/secondary/...
build/secondary/third_party/android_tools/BUILD.gn:77:
":android_support_v7_recyclerview_resources",
nit: sort

[aurimas (slooooooooow), 2015-06-01 22:17:38]

https://chromiumcodereview.appspot.com/1161933005/diff/80001/build/secondary/...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1161933005/diff/80001/build/secondary/...
build/secondary/third_party/android_tools/BUILD.gn:77:
":android_support_v7_recyclerview_resources",
On 2015/06/01 at 22:06:51, cjhopman wrote:
> nit: sort

Done

[aurimas (slooooooooow), 2015-06-01 22:17:44]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-01 22:17:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
fdegans@chromium.org, pcc@chromium.org, newt@chromium.org, cjhopman@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1161933005/#ps100001 (title: "Reorder
deps")

[commit-bot: I haz the power, 2015-06-01 23:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161933005/100001

[commit-bot: I haz the power, 2015-06-02 02:05:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-06-02 02:06:34]

Patchset 6 (id:??) landed as
https://crrev.com/a9d97645e8bfbf0b60fd667a504f2740aadc553f
Cr-Commit-Position: refs/heads/master@{#332323}

[Nico, 2015-06-02 21:29:11]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-06-02 21:29:12]

This broke building the android/asan compiler:

http://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/887
Invalid platform name: android-14
Please use --platform=<name> with one of: android-16 android-17 android-18
android-19 android-21

I suppose we should just bump up that number around line 678 in
tools/clang/scripts/update.sh (where it says "android-14")?

[aurimas (slooooooooow), 2015-06-02 21:32:45]

On 2015/06/02 at 21:29:12, thakis wrote:
> This broke building the android/asan compiler:
> 
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/887
> Invalid platform name: android-14
> Please use --platform=<name> with one of: android-16 android-17 android-18
android-19 android-21
> 
> I suppose we should just bump up that number around line 678 in
tools/clang/scripts/update.sh (where it says "android-14")?

@thakis: https://codereview.chromium.org/1161973004/

[hans, 2015-06-02 21:33:24]

On 2015/06/02 21:29:12, Nico wrote:
> This broke building the android/asan compiler:
> 
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/887
> Invalid platform name: android-14
> Please use --platform=<name> with one of: android-16 android-17 android-18
> android-19 android-21
> 
> I suppose we should just bump up that number around line 678 in
> tools/clang/scripts/update.sh (where it says "android-14")?

eugenis's recent patch includes bumping that to 19.