Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: tests/standalone/vmservice/isolate_class_field_test.dart

Issue 116193003: Fix checked mode failures in vmservice tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/vmservice/isolate_class_field_test.dart
diff --git a/tests/standalone/vmservice/isolate_class_field_test.dart b/tests/standalone/vmservice/isolate_class_field_test.dart
index 639aca189e3dbf9c653038d8f2d0d3b43b1274b6..9c84cc6cbeb4e6afaf06e07ea11f3dfbcf680992 100644
--- a/tests/standalone/vmservice/isolate_class_field_test.dart
+++ b/tests/standalone/vmservice/isolate_class_field_test.dart
@@ -10,8 +10,8 @@ import 'package:expect/expect.dart';
class BananaClassTest {
int port;
- int isolate_id;
- int class_id;
+ String isolate_id;
+ String class_id;
BananaClassTest(this.port, this.isolate_id, this.class_id);
_testFieldA(Map field) {
@@ -75,8 +75,8 @@ class BananaClassTest {
class BadBananaClassTest {
int port;
- int isolate_id;
- int class_id;
+ String isolate_id;
+ String class_id;
BadBananaClassTest(this.port, this.isolate_id, this.class_id);
_testFieldV(Map field) {
@@ -142,8 +142,8 @@ class ClassTableTest extends VmServiceRequestHelper {
ClassTableTest(port, id) :
super('http://127.0.0.1:$port/$id/classes/');
- int banana_class_id;
- int bad_banana_class_id;
+ String banana_class_id;
+ String bad_banana_class_id;
onRequestCompleted(Map reply) {
ClassTableHelper helper = new ClassTableHelper(reply);
@@ -157,7 +157,7 @@ class ClassTableTest extends VmServiceRequestHelper {
class IsolateListTest extends VmServiceRequestHelper {
IsolateListTest(port) : super('http://127.0.0.1:$port/isolates');
- int _isolateId;
+ String _isolateId;
onRequestCompleted(Map reply) {
IsolateListTester tester = new IsolateListTester(reply);
tester.checkIsolateCount(1);
« no previous file with comments | « tests/standalone/vmservice/isolate_bad_object_test.dart ('k') | tests/standalone/vmservice/isolate_class_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698