Issue 1161913003: Opt for advanced blend at creation time in CrCustomXfermode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161913003: Opt for advanced blend at creation time in CrCustomXfermode (Closed)

Created:
5 years, 6 months ago by Chris Dalton

Modified:
5 years, 6 months ago

Reviewers:
egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Opt for advanced blend at creation time in CrCustomXfermode Modifies GrCustomXfermode to decide at creation time whether it will use advanced blend, instead of deciding during getOptimizations. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f0df189aa204ac54ca431ea9dd287ac0068ea809

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -34 lines)			Patch
	M	src/gpu/effects/GrCustomXfermode.cpp	View		8 chunks	+31 lines, -34 lines	0 comments	Download
	M	src/gpu/effects/GrCustomXfermodePriv.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Chris Dalton

I'm just pulling this out of the advanced blend patch so it doesn't gate the ...

5 years, 6 months ago (2015-06-05 20:10:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161913003/1

5 years, 6 months ago (2015-06-05 20:19:14 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 20:26:26 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f0df189aa204ac54ca431ea9dd287ac0068ea809