Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: Source/core/layout/LayoutView.cpp

Issue 1161913002: Remove outdated FIXME (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/LayoutObjectChildList.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 } 368 }
369 369
370 void LayoutView::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalidatio nState) 370 void LayoutView::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalidatio nState)
371 { 371 {
372 ASSERT(!needsLayout()); 372 ASSERT(!needsLayout());
373 373
374 // We specifically need to issue paint invalidations for the viewRect since other layoutObjects 374 // We specifically need to issue paint invalidations for the viewRect since other layoutObjects
375 // short-circuit on full-paint invalidation. 375 // short-circuit on full-paint invalidation.
376 LayoutRect dirtyRect = viewRect(); 376 LayoutRect dirtyRect = viewRect();
377 if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) { 377 if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) {
378 const LayoutBoxModelObject* paintInvalidationContainer = &paintInvalidat ionState.paintInvalidationContainer(); 378 const LayoutBoxModelObject& paintInvalidationContainer = paintInvalidati onState.paintInvalidationContainer();
379 DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(this, paintInval idationContainer, dirtyRect, &paintInvalidationState); 379 DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(this, &paintInva lidationContainer, dirtyRect, &paintInvalidationState);
380 invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, Pai ntInvalidationFull); 380 invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, Pai ntInvalidationFull);
381 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) 381 if (RuntimeEnabledFeatures::slimmingPaintEnabled())
382 invalidateDisplayItemClients(*paintInvalidationContainer); 382 invalidateDisplayItemClients(paintInvalidationContainer);
383 } 383 }
384 LayoutBlock::invalidateTreeIfNeeded(paintInvalidationState); 384 LayoutBlock::invalidateTreeIfNeeded(paintInvalidationState);
385 } 385 }
386 386
387 void LayoutView::invalidatePaintForRectangle(const LayoutRect& paintInvalidation Rect, PaintInvalidationReason invalidationReason) const 387 void LayoutView::invalidatePaintForRectangle(const LayoutRect& paintInvalidation Rect, PaintInvalidationReason invalidationReason) const
388 { 388 {
389 ASSERT(!paintInvalidationRect.isEmpty()); 389 ASSERT(!paintInvalidationRect.isEmpty());
390 390
391 if (document().printing() || !m_frameView) 391 if (document().printing() || !m_frameView)
392 return; 392 return;
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
975 return viewHeight(IncludeScrollbars) / scale; 975 return viewHeight(IncludeScrollbars) / scale;
976 } 976 }
977 977
978 void LayoutView::willBeDestroyed() 978 void LayoutView::willBeDestroyed()
979 { 979 {
980 LayoutBlockFlow::willBeDestroyed(); 980 LayoutBlockFlow::willBeDestroyed();
981 m_compositor.clear(); 981 m_compositor.clear();
982 } 982 }
983 983
984 } // namespace blink 984 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutObjectChildList.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698