Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/core/inspector/InspectorTraceEvents.cpp

Issue 1161913002: Remove outdated FIXME (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.h ('k') | Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/inspector/InspectorTraceEvents.h" 6 #include "core/inspector/InspectorTraceEvents.h"
7 7
8 #include "bindings/core/v8/ScriptCallStackFactory.h" 8 #include "bindings/core/v8/ScriptCallStackFactory.h"
9 #include "bindings/core/v8/ScriptSourceCode.h" 9 #include "bindings/core/v8/ScriptSourceCode.h"
10 #include "core/animation/Animation.h" 10 #include "core/animation/Animation.h"
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 ASSERT(layoutObject); 362 ASSERT(layoutObject);
363 RefPtr<TracedValue> value = TracedValue::create(); 363 RefPtr<TracedValue> value = TracedValue::create();
364 value->setString("frame", toHexString(layoutObject->frame())); 364 value->setString("frame", toHexString(layoutObject->frame()));
365 setGeneratingNodeInfo(value.get(), layoutObject, "nodeId", "nodeName"); 365 setGeneratingNodeInfo(value.get(), layoutObject, "nodeId", "nodeName");
366 value->setString("reason", reason); 366 value->setString("reason", reason);
367 if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(m axInvalidationTrackingCallstackSize, true)) 367 if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(m axInvalidationTrackingCallstackSize, true))
368 stackTrace->toTracedValue(value.get(), "stackTrace"); 368 stackTrace->toTracedValue(value.get(), "stackTrace");
369 return value.release(); 369 return value.release();
370 } 370 }
371 371
372 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorPaintInvalidationTrack ingEvent::data(const LayoutObject* layoutObject, const LayoutObject* paintContai ner) 372 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorPaintInvalidationTrack ingEvent::data(const LayoutObject* layoutObject, const LayoutObject& paintContai ner)
373 { 373 {
374 ASSERT(layoutObject); 374 ASSERT(layoutObject);
375 RefPtr<TracedValue> value = TracedValue::create(); 375 RefPtr<TracedValue> value = TracedValue::create();
376 value->setString("frame", toHexString(layoutObject->frame())); 376 value->setString("frame", toHexString(layoutObject->frame()));
377 setGeneratingNodeInfo(value.get(), paintContainer, "paintId"); 377 setGeneratingNodeInfo(value.get(), &paintContainer, "paintId");
378 setGeneratingNodeInfo(value.get(), layoutObject, "nodeId", "nodeName"); 378 setGeneratingNodeInfo(value.get(), layoutObject, "nodeId", "nodeName");
379 return value.release(); 379 return value.release();
380 } 380 }
381 381
382 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorScrollInvalidationTrac kingEvent::data(const LayoutObject& layoutObject) 382 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorScrollInvalidationTrac kingEvent::data(const LayoutObject& layoutObject)
383 { 383 {
384 static const char ScrollInvalidationReason[] = "Scroll with viewport-constra ined element"; 384 static const char ScrollInvalidationReason[] = "Scroll with viewport-constra ined element";
385 385
386 RefPtr<TracedValue> value = TracedValue::create(); 386 RefPtr<TracedValue> value = TracedValue::create();
387 value->setString("frame", toHexString(layoutObject.frame())); 387 value->setString("frame", toHexString(layoutObject.frame()));
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 } 752 }
753 753
754 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorAnimationStateEvent::d ata(const Animation& player) 754 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorAnimationStateEvent::d ata(const Animation& player)
755 { 755 {
756 RefPtr<TracedValue> value = TracedValue::create(); 756 RefPtr<TracedValue> value = TracedValue::create();
757 value->setString("state", player.playState()); 757 value->setString("state", player.playState());
758 return value.release(); 758 return value.release();
759 } 759 }
760 760
761 } 761 }
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.h ('k') | Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698