Issue 1161903005: Revert of [DevTools] Fix favicon images on chrome://inspect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161903005: Revert of [DevTools] Fix favicon images on chrome://inspect (Closed)

Created:
5 years, 6 months ago by dgozman

Modified:
5 years, 6 months ago

Reviewers:
michaelbai, vkuzkokov, David Trainor- moved to gerrit

CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of [DevTools] Fix favicon images on chrome://inspect (patchset #3 id:40001 of https://codereview.chromium.org/1124023004/) Reason for revert: Performance regression. See http://crbug.com/489208. BUG=489208 Original issue's description: > [DevTools] Fix favicon images on chrome://inspect > > Favicon is resolved as data URL to avoid discrepancies if favicon depends on environment (e.g. user-agent). > > BUG=461581 > > Committed: https://crrev.com/c49162e3fa9557ce8a42fd1c5562e0d4ae825dc6 > Cr-Commit-Position: refs/heads/master@{#329831} TBR=michaelbai@chromium.org,dtrainor@chromium.org,vkuzkokov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461581 Committed: https://crrev.com/cc117f684861850124e8ef820f8d65e90a4f624c Cr-Commit-Position: refs/heads/master@{#332599}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -46 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/Tab.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/android/dev_tools_discovery_provider_android.cc	View	3 chunks	+10 lines, -33 lines	0 comments	Download
M	chrome/browser/android/tab_android.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/android/tab_android.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

dgozman

Created Revert of [DevTools] Fix favicon images on chrome://inspect

5 years, 6 months ago (2015-06-03 12:05:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161903005/1

5 years, 6 months ago (2015-06-03 12:06:59 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-03 12:08:57 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cc117f684861850124e8ef820f8d65e90a4f624c
Cr-Commit-Position: refs/heads/master@{#332599}