Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1161903004: Oilpan: Don't call didV8GC in V8's minor GC (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Don't call didV8GC in V8's minor GC didV8GC is used to notify Oilpan that a V8 GC runs and a lot of wrappers would have been disposed. This is a useful signal for Oilpan to decrease the estimated live object count. Specifically, Oilpan halves the estimated live object count when didV8GC is called. Currently didV8GC is called in both minor and major GCs. This is too much because minor GCs are called very frequently. As a result, the estimated live object count goes down too quickly and we end up with scheduling idle GCs too much. This CL changes didV8GC so that it is called only in major GCs. BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/bindings/core/v8/V8GCController.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
haraken
PTAL
4 years, 11 months ago (2015-06-03 09:41:32 UTC) #2
sof
lgtm, what effect does the slower decay of "estimated object size" have?
4 years, 11 months ago (2015-06-03 12:04:09 UTC) #3
haraken
> what effect does the slower decay of "estimated object size" have? It will delay ...
4 years, 11 months ago (2015-06-03 12:10:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161903004/1
4 years, 11 months ago (2015-06-03 12:11:33 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 14:00:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196400

Powered by Google App Engine
This is Rietveld 408576698