Change Layout::adjustCompositedContainerForSpecialAncestors into an overloaded version of container…

Source/core/layout/LayoutObject.cpp

Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index da3f4f0bef5a2227494fd688dd5881ee0f33e968..dc0427881624d29ed19d4b278476d3e176ee2d33 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -1048,7 +1048,7 @@ void LayoutObject::paint(const PaintInfo&, const LayoutPoint&)
 const LayoutBoxModelObject* LayoutObject::containerForPaintInvalidation() const
 {
     RELEASE_ASSERT(isRooted());
-    return adjustCompositedContainerForSpecialAncestors(enclosingCompositedContainer());
+    return containerForPaintInvalidation(enclosingCompositedContainer());
 }
 
 const LayoutBoxModelObject* LayoutObject::enclosingCompositedContainer() const
@@ -1062,7 +1062,7 @@ const LayoutBoxModelObject* LayoutObject::enclosingCompositedContainer() const
     return container;
 }
 
-const LayoutBoxModelObject* LayoutObject::adjustCompositedContainerForSpecialAncestors(const LayoutBoxModelObject* paintInvalidationContainer) const
+const LayoutBoxModelObject* LayoutObject::containerForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const

[leviw_travelin_and_unemployed, 2015/06/02 17:49:51]

I like the simplification ideal behind this patch, but I'm not convinced it's
actually clearer.

Calling LayoutObject::containerForPaintInvalidation with a LayoutBoxModelObject*
parameter named "paintInvalidationContainer" doesn't explain to me what's
actually going on in the function. Also passing in a null pointer to that method
doesn't do the same thing as calling LayoutObject::containerForPaintInvalidation
without an argument, even though it's clear on inspection that it's prepared to
deal with null pointers.

The previous name gave some vague idea of what the method actually did, though
I'll certainly agree it's not very clear.

 {
     if (paintInvalidationContainer)
         return paintInvalidationContainer;