Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Issue 1161863003: Add an additional content_shell per worker for running virtual tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@virtual_reference_flags
Patch Set: fix docstring for Driver.run_test() Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
index 7ac88d3e8789ed23aeb9df2ea38b3ad2ea372855..3efb9606168236843afbd7639c77c13d6290a11d 100644
--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
@@ -777,6 +777,19 @@ class RunTest(unittest.TestCase, StreamTestingMixin):
def test_reftest_with_virtual_reference(self):
_, err, _ = logging_run(['--details', 'virtual/virtual_passes/passes/reftest.html'], tests_included=True)
self.assertTrue('ref: virtual/virtual_passes/passes/reftest-expected.html' in err.getvalue())
+ self.assertTrue(
+ re.search('args: --virtual-arg\s*reference_args: --virtual-arg\s*ref:', err.getvalue()))
+
+ def test_reftest_virtual_references_use_default_args(self):
+ test_name = 'virtual/references_use_default_args/passes/reftest.html'
+ run_details, err, _ = logging_run(['--details', test_name], tests_included=True)
+ self.assertEqual(run_details.exit_code, 0)
+ self.assertEqual(run_details.initial_results.total, 1)
+ test_result = run_details.initial_results.all_results[0]
+ self.assertEqual(test_result.test_name, test_name)
+ self.assertEqual(test_result.references[0], 'passes/reftest-expected.html')
+ # reference_args should be empty since we are using the default flags.
+ self.assertTrue(re.search('reference_args:\s*ref:', err.getvalue()))
def test_additional_platform_directory(self):
self.assertTrue(passing_run(['--additional-platform-directory', '/tmp/foo']))

Powered by Google App Engine
This is Rietveld 408576698