Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: skia/BUILD.gn

Issue 1161853008: skia: Simplify SSE2 logic a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/skia.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 5fedacf3b149bcb209b92dcc99d4ebb7bb833ca4..3b4b0a61dc40f55b3e5d9a7e306985820b8ab649 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -318,6 +318,18 @@ component("skia") {
"ext/skia_utils_win.h",
]
+ if (current_cpu == "x86" || current_cpu == "x64") {
+ sources += [
+ "ext/convolver_SSE2.cc",
+ "ext/convolver_SSE2.h",
+ ]
+ } else if (current_cpu == "mipsel" && mips_dsp_rev >= 2) {
+ sources += [
+ "ext/convolver_mips_dspr2.cc",
+ "ext/convolver_mips_dspr2.h",
+ ]
+ }
+
# The skia gypi values are relative to the skia_dir, so we need to rebase.
sources += gypi_skia_core.sources
sources += gypi_skia_effects.sources
@@ -552,12 +564,7 @@ source_set("skia_opts") {
if (current_cpu == "x86" || current_cpu == "x64") {
sources = gypi_skia_opts.sse2_sources + gypi_skia_opts.ssse3_sources +
- gypi_skia_opts.sse41_sources +
- [
- # Chrome-specific.
- "ext/convolver_SSE2.cc",
- "ext/convolver_SSE2.h",
- ]
+ gypi_skia_opts.sse41_sources
if (!is_win || is_clang) {
cflags += [ "-msse4.1" ]
@@ -590,13 +597,6 @@ source_set("skia_opts") {
if (mips_dsp_rev >= 1) {
sources = gypi_skia_opts.mips_dsp_sources
- if (mips_dsp_rev >= 2) {
- sources += [
- # Chrome-specific.
- "ext/convolver_mips_dspr2.cc",
- "ext/convolver_mips_dspr2.h",
- ]
- }
} else {
sources = gypi_skia_opts.none_sources
}
« no previous file with comments | « no previous file | skia/skia.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698